Bugzilla – Attachment 194960 Details for
Bug 41582
Tidy kohaTable block - opac
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41582: (QA follow-up) Fix syntax errors in defaulttab switch
Bug-41582-QA-follow-up-Fix-syntax-errors-in-defaul.patch (text/plain), 1.51 KB, created by
Paul Derscheid
on 2026-03-09 07:44:34 UTC
(
hide
)
Description:
Bug 41582: (QA follow-up) Fix syntax errors in defaulttab switch
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-03-09 07:44:34 UTC
Size:
1.51 KB
patch
obsolete
>From 201cd1789e36d59b92728857fa81a6d6b323186f Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Fri, 6 Mar 2026 18:30:53 +0100 >Subject: [PATCH] Bug 41582: (QA follow-up) Fix syntax errors in defaulttab > switch > >- Missing colon on case 'media' causes a hard JS SyntaxError > breaking the entire script block on page load >- Add missing semicolons after break statements > >To test: >- Open an OPAC detail page for a record with media tab >- Verify no JS errors in the console >- Verify the correct default tab is selected > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index e1ec4232046..033af536386 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1938,10 +1938,10 @@ > case 'subscriptions': > case 'serialcollection': > showBsTab("bibliodescriptions", defaulttab); >- break >- case 'media' >+ break; >+ case 'media': > showBsTab("bibliodescriptions", "html5media"); >- break >+ break; > default: > showBsTab("bibliodescriptions", "holdings"); > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41582
:
191174
|
191175
|
191176
|
191177
|
191178
|
191179
|
191180
|
191181
|
191182
|
191183
|
191184
|
191185
|
191186
|
191187
|
191188
|
191450
|
191451
|
191452
|
191453
|
191454
|
191455
|
191456
|
191457
|
191458
|
191459
|
191460
|
191461
|
191462
|
191463
|
191464
|
191465
|
191569
|
194666
|
194667
|
194668
|
194669
|
194670
|
194671
|
194672
|
194673
|
194674
|
194675
|
194676
|
194677
|
194678
|
194679
|
194680
|
194681
|
194682
|
194943
|
194944
|
194945
|
194946
|
194947
|
194948
|
194949
|
194950
|
194951
|
194952
|
194953
|
194954
|
194955
|
194956
|
194957
|
194958
|
194959
| 194960 |
194961
|
194962
|
195225