Bugzilla – Attachment 194962 Details for
Bug 41582
Tidy kohaTable block - opac
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41582: (QA follow-up) Fix missing prefs prefix for OPACLocalCoverImages
Bug-41582-QA-follow-up-Fix-missing-prefs-prefix-fo.patch (text/plain), 1.60 KB, created by
Paul Derscheid
on 2026-03-09 07:44:39 UTC
(
hide
)
Description:
Bug 41582: (QA follow-up) Fix missing prefs prefix for OPACLocalCoverImages
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-03-09 07:44:39 UTC
Size:
1.60 KB
patch
obsolete
>From 93366ba91afcbb1c9b3e22e558a19d0498a3d572 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Fri, 6 Mar 2026 18:32:02 +0100 >Subject: [PATCH] Bug 41582: (QA follow-up) Fix missing prefs prefix for > OPACLocalCoverImages > >- The shelf browser previous-navigation AJAX callback references > OPACLocalCoverImages without the prefs. prefix, causing a > ReferenceError at runtime >- The next-navigation callback correctly uses prefs.OPACLocalCoverImages > >To test: >- Enable OPACLocalCoverImages system preference >- Open an OPAC detail page with the shelf browser enabled >- Click the previous arrow in the shelf browser >- Verify local cover images load without JS errors > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index e5e01fe3ad5..b0899aabb6c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -2109,7 +2109,7 @@ > if (prefs.OpenLibraryCovers){ > KOHA.OpenLibrary.GetCoverFromIsbn(); > } >- if (OPACLocalCoverImages){ >+ if (prefs.OPACLocalCoverImages){ > KOHA.LocalCover.GetCoverFromBibnumber(true); > } > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41582
:
191174
|
191175
|
191176
|
191177
|
191178
|
191179
|
191180
|
191181
|
191182
|
191183
|
191184
|
191185
|
191186
|
191187
|
191188
|
191450
|
191451
|
191452
|
191453
|
191454
|
191455
|
191456
|
191457
|
191458
|
191459
|
191460
|
191461
|
191462
|
191463
|
191464
|
191465
|
191569
|
194666
|
194667
|
194668
|
194669
|
194670
|
194671
|
194672
|
194673
|
194674
|
194675
|
194676
|
194677
|
194678
|
194679
|
194680
|
194681
|
194682
|
194943
|
194944
|
194945
|
194946
|
194947
|
194948
|
194949
|
194950
|
194951
|
194952
|
194953
|
194954
|
194955
|
194956
|
194957
|
194958
|
194959
|
194960
|
194961
| 194962 |
195225