Bugzilla – Attachment 194977 Details for
Bug 41580
Tidy kohaTable block - tools
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41580: (QA follow-up) Fix suspend status check in batch modify holds
Bug-41580-QA-follow-up-Fix-suspend-status-check-in.patch (text/plain), 1.87 KB, created by
Paul Derscheid
on 2026-03-09 08:49:52 UTC
(
hide
)
Description:
Bug 41580: (QA follow-up) Fix suspend status check in batch modify holds
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-03-09 08:49:52 UTC
Size:
1.87 KB
patch
obsolete
>From ac57cc05c21d488be1857de911324519c079f7d8 Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Fri, 6 Mar 2026 17:58:06 +0100 >Subject: [PATCH] Bug 41580: (QA follow-up) Fix suspend status check in batch > modify holds >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >- Fix typo: hold.suspened â hold.suspended, the suspension check > never fired because the property name was misspelled >- Restore DOM update: the tidy replaced > \$("#new_suspend_status").val("1") with a local variable assignment > that had no effect on the submitted form data > >To test: >- Go to Tools â Batch modify holds >- Load holds that are not suspended >- Set a suspend date without changing suspend status >- Submit and verify the suspend status is automatically set to 1 > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > .../intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >index df2eba4502a..041ab65a594 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >@@ -616,13 +616,13 @@ > var suspended = false; > > hold_ids.forEach(function (hold) { >- if (hold.suspened) { >+ if (hold.suspended) { > suspended = true; > } > }); > > if ((!new_suspend_status || new_suspend_status == "0" || !suspended) && new_suspend_date) { >- new_suspend_status = 1; >+ $("#new_suspend_status").val("1"); > } > > if (errors.length > 0) { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41580
:
191163
|
191164
|
191165
|
191166
|
191167
|
191168
|
191169
|
191170
|
191171
|
191697
|
191698
|
191699
|
191700
|
191701
|
191702
|
191703
|
191704
|
191705
|
191706
|
191707
|
194965
|
194966
|
194967
|
194968
|
194969
|
194970
|
194971
|
194972
|
194973
|
194974
|
194975
|
194976
| 194977 |
194978
|
194979