Bugzilla – Attachment 194978 Details for
Bug 41580
Tidy kohaTable block - tools
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41580: (QA follow-up) Fix variable name mismatch in batch delete records
Bug-41580-QA-follow-up-Fix-variable-name-mismatch-.patch (text/plain), 1.55 KB, created by
Paul Derscheid
on 2026-03-09 08:49:55 UTC
(
hide
)
Description:
Bug 41580: (QA follow-up) Fix variable name mismatch in batch delete records
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2026-03-09 08:49:55 UTC
Size:
1.55 KB
patch
obsolete
>From 3af562eac2e1db0be902f0461b8a5c8dba5635fd Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Fri, 6 Mar 2026 17:58:16 +0100 >Subject: [PATCH] Bug 41580: (QA follow-up) Fix variable name mismatch in batch > delete records >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >- The tidy declared const record_type but the code references > recordtype (no underscore), causing a ReferenceError >- Rename to match the existing usage > >To test: >- Go to Tools รข Batch delete records >- Upload/select bibliographic records with checked out items >- Verify the red cross and yellow highlight appear for > non-deletable records > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > .../intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >index 324f0970676..77e88909310 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >@@ -264,7 +264,7 @@ > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] > <script> >- const record_type = "[% recordtype | html %]"; >+ const recordtype = "[% recordtype | html %]"; > </script> > <script> > var MSG_CANNOT_BE_DELETED = _("This record cannot be deleted, at least one item is currently checked out."); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41580
:
191163
|
191164
|
191165
|
191166
|
191167
|
191168
|
191169
|
191170
|
191171
|
191697
|
191698
|
191699
|
191700
|
191701
|
191702
|
191703
|
191704
|
191705
|
191706
|
191707
|
194965
|
194966
|
194967
|
194968
|
194969
|
194970
|
194971
|
194972
|
194973
|
194974
|
194975
|
194976
|
194977
| 194978 |
194979