Bugzilla – Attachment 195087 Details for
Bug 40136
Record diff in action logs when modifying a patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40136: (QA follow-up) Fix tests
d069141.patch (text/plain), 5.90 KB, created by
Lisette Scheer
on 2026-03-10 14:30:04 UTC
(
hide
)
Description:
Bug 40136: (QA follow-up) Fix tests
Filename:
MIME Type:
Creator:
Lisette Scheer
Created:
2026-03-10 14:30:04 UTC
Size:
5.90 KB
patch
obsolete
>From d069141d5787fe23b8369c9b7c1437c6886b528a Mon Sep 17 00:00:00 2001 >From: Lisette Scheer <lisette@bywatersolutions.com> >Date: Tue, 10 Mar 2026 14:27:44 +0000 >Subject: [PATCH] Bug 40136: (QA follow-up) Fix tests > >Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> >--- > t/db_dependent/Koha/Patrons.t | 31 +++++++++++-------------------- > 1 file changed, 11 insertions(+), 20 deletions(-) > >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index ed365362440..fbea2933379 100755 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -502,8 +502,7 @@ subtest 'renew_account' => sub { > ); > my $number_of_logs = > $schema->resultset('ActionLog') >- ->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } ) >- ->count; >+ ->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count; > is( $number_of_logs, 1, 'With BorrowersLog, Koha::Patron->renew_account should have logged' ); > > t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'now' ); >@@ -519,8 +518,7 @@ subtest 'renew_account' => sub { > is( dt_from_string($retrieved_expiry_date), $a_year_later, "today + 12 months must be $a_year_later" ); > $number_of_logs = > $schema->resultset('ActionLog') >- ->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } ) >- ->count; >+ ->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count; > is( $number_of_logs, 1, 'Without BorrowersLog, Koha::Patron->renew_account should not have logged' ); > > t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'combination' ); >@@ -656,8 +654,7 @@ subtest "delete" => sub { > > my $number_of_logs = > $schema->resultset('ActionLog') >- ->search( { module => 'MEMBERS', action => 'DELETE', object => $patron->borrowernumber } ) >- ->count; >+ ->search( { module => 'MEMBERS', action => 'DELETE', object => $patron->borrowernumber } )->count; > is( $number_of_logs, 1, 'With BorrowersLog, Koha::Patron->delete should have logged' ); > > # Test deletion with designated fallback owner >@@ -730,8 +727,7 @@ subtest 'add_enrolment_fee_if_needed' => sub { > foreach ( keys %{$enrolmentfees} ) { > ( Koha::Patron::Categories->find($_) > // $builder->build_object( { class => 'Koha::Patron::Categories', value => { categorycode => $_ } } ) ) >- ->enrolmentfee( $enrolmentfees->{$_} ) >- ->store; >+ ->enrolmentfee( $enrolmentfees->{$_} )->store; > } > my $enrolmentfee_K = $enrolmentfees->{K}; > my $enrolmentfee_J = $enrolmentfees->{J}; >@@ -2658,8 +2654,7 @@ subtest '->set_password' => sub { > > my $number_of_logs = > $schema->resultset('ActionLog') >- ->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } ) >- ->count; >+ ->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count; > is( $number_of_logs, 0, 'Without BorrowersLog, Koha::Patron->set_password doesn\'t log password changes' ); > > # Enable logging password changes >@@ -3189,8 +3184,8 @@ subtest "search_patrons_to_update_category tests" => sub { > class => 'Koha::Patrons', > value => { > categorycode => $category_code, >- dateofbirth => $current_dt->clone->subtract( years => $category->upperagelimit + 1 ) >- ->subtract( days => 1 ) >+ dateofbirth => >+ $current_dt->clone->subtract( years => $category->upperagelimit + 1 )->subtract( days => 1 ) > ->ymd, > } > } >@@ -3640,8 +3635,7 @@ subtest 'filter_by_have_permission' => sub { > is_deeply( > [ > Koha::Patrons->search( { branchcode => $library->branchcode } ) >- ->filter_by_have_permission('suggestions.suggestions_manage') >- ->get_column('borrowernumber') >+ ->filter_by_have_permission('suggestions.suggestions_manage')->get_column('borrowernumber') > ], > [ $patron_1->borrowernumber, $patron_2->borrowernumber ], > 'Superlibrarian and patron with suggestions.suggestions_manage' >@@ -3650,8 +3644,7 @@ subtest 'filter_by_have_permission' => sub { > is_deeply( > [ > Koha::Patrons->search( { branchcode => $library->branchcode } ) >- ->filter_by_have_permission('acquisition.order_manage') >- ->get_column('borrowernumber') >+ ->filter_by_have_permission('acquisition.order_manage')->get_column('borrowernumber') > ], > [ $patron_1->borrowernumber, $patron_3->borrowernumber ], > 'Superlibrarian and patron with acquisition.order_manage' >@@ -3660,8 +3653,7 @@ subtest 'filter_by_have_permission' => sub { > is_deeply( > [ > Koha::Patrons->search( { branchcode => $library->branchcode } ) >- ->filter_by_have_permission('parameters.manage_cities') >- ->get_column('borrowernumber') >+ ->filter_by_have_permission('parameters.manage_cities')->get_column('borrowernumber') > ], > [ $patron_1->borrowernumber ], > 'Only Superlibrarian is returned' >@@ -3669,8 +3661,7 @@ subtest 'filter_by_have_permission' => sub { > > is_deeply( > [ >- Koha::Patrons->search( { branchcode => $library->branchcode } ) >- ->filter_by_have_permission('suggestions') >+ Koha::Patrons->search( { branchcode => $library->branchcode } )->filter_by_have_permission('suggestions') > ->get_column('borrowernumber') > ], > [ $patron_1->borrowernumber, $patron_2->borrowernumber ], >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40136
:
194872
|
194940
|
195036
|
195037
|
195046
|
195083
|
195084
|
195085
|
195086
| 195087