Bugzilla – Attachment 195157 Details for
Bug 42071
Suggestion does not load when viewing the suggestion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 42071: Add 'show' to options that load a single suggestion
Bug-42071-Add-show-to-options-that-load-a-single-s.patch (text/plain), 1.33 KB, created by
Pedro Amorim
on 2026-03-12 04:52:30 UTC
(
hide
)
Description:
Bug 42071: Add 'show' to options that load a single suggestion
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2026-03-12 04:52:30 UTC
Size:
1.33 KB
patch
obsolete
>From d41b47b5b2d30c09231f32f9391f1fab1484d5a7 Mon Sep 17 00:00:00 2001 >From: Lisette Scheer <lisette@bywatersolutions.com> >Date: Wed, 11 Mar 2026 21:16:30 +0000 >Subject: [PATCH] Bug 42071: Add 'show' to options that load a single > suggestion > >Test plan: > >Before applying the patch: >1. Go to acquisitions >2. Go to Purchase Suggestions >3. Create a purchase suggestion (for ease of testing, select Centerville for the library) >4. On the table, click on the suggestion number >5. Observe the suggestion does not populate, including the breadcrumbs, but the url does contain the suggestion number. >6. Apply the patch >7. restart_all >8. Rpeat steps 1-4 >9. Observe the suggestion now populates and can be edited. > >Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> >--- > suggestion/suggestion.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 5e5689002ff..3b61a17c537 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -101,7 +101,7 @@ my $reasonsloop = GetAuthorisedValues("SUGGEST"); > > my $suggestion_ref = { $input->Vars }; > my $stored_suggestion; >-if ( $op eq "edit_form" ) { >+if ( $op eq "edit_form" || $op eq "show" ) { > $stored_suggestion = Koha::Suggestions->find( $input->param('suggestionid') ) if $input->param('suggestionid'); > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 42071
:
195140
| 195157