Bugzilla – Attachment 195170 Details for
Bug 31736
Context for translation: "All"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31736: Editing 'All' to 'All patron categories'
Bug-31736-Editing-All-to-All-patron-categories.patch (text/plain), 7.38 KB, created by
Owen Leonard
on 2026-03-12 12:12:49 UTC
(
hide
)
Description:
Bug 31736: Editing 'All' to 'All patron categories'
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2026-03-12 12:12:49 UTC
Size:
7.38 KB
patch
obsolete
>From b28521715835f8cb30aa05d5c6dccb796741f43e Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Wed, 11 Mar 2026 23:18:39 +0000 >Subject: [PATCH] Bug 31736: Editing 'All' to 'All patron categories' > >This patch edit the term 'All' to 'All patron categories', beacause All >can have different genders depending on the used language ( in french >All could mean 'tous for 'male-gendered' things and 'toutes' for >'female-gendered' things). > >1. Apply patch >2. View the following pages > --> The pages work (no errors) > --> 'All' should be replace by 'All patron categories' > --> No spelling errors in 'All' patron categories > > - Administration > Circulation and fines rules > Patron category > column ('All patron categories' in existing rule) > - Administration > Circulation and fines rules > Patron category > column ('All patron categories' in drop-down to create a new rule) > - Administration > Circulation and fines rules > Default waiting hold > cancellation policy > Patron category column ('All patron > categories' in existing rule) > - Administration > Circulation and fines rules > Default waiting hold > cancellation policy > Patron category column ('All patron > categories' in drop-down to create a new rule) > - Administration > Circulation and fines rules > Default article > request fees > Patron category column ('All patron categories' in > existing rule) > - Administration > Circulation and fines rules > Default article > request fees > Patron category column ('All patron categories' in > drop-down to create a new rule) > - Installer > Onboarding > New circulation rule (Patron category) > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/admin/smart-rules.tt | 16 ++++++++-------- > .../en/modules/onboarding/onboardingstep5.tt | 2 +- > 2 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 84f323ab327..da5201bf8fa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -234,7 +234,7 @@ > > > <td data-code="[% c | html %]"> > [% IF c == undef %] >- <em>All</em> >+ <em>All patron categories</em> > [% ELSE %] > [% Categories.GetName(c) | html %] > [% END %] >@@ -463,7 +463,7 @@ > <td>2</td> > <td> > <select name="categorycode" id="categorycode"> >- <option value="*">All</option> >+ <option value="*">All patron categories</option> > [% FOREACH patron_category IN patron_categories %] > <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option> > [% END %] >@@ -927,7 +927,7 @@ > <tr> > <td> > [% IF c == undef %] >- <em>All</em> >+ <em>All patron categories</em> > [% ELSE %] > [% Categories.GetName(c) | html %] > [% END %] >@@ -958,7 +958,7 @@ > <tr> > <td> > <select name="waiting_hold_cancellation_category" id="waiting_hold_cancellation_category"> >- <option value="*">All</option> >+ <option value="*">All patron categories</option> > [% FOREACH patron_category IN patron_categories %] > <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option> > [% END %] >@@ -1011,7 +1011,7 @@ > [% IF ( open_article_requests_limit.defined && open_article_requests_limit != '' ) %] > <tr> > [% IF c == undef %] >- <td><em>All</em></td> >+ <td><em>All patron categories</em></td> > [% ELSE %] > <td> [% Categories.GetName(c) | html %] </td> > [% END %] >@@ -1032,7 +1032,7 @@ > <tr> > <td> > <select name="categorycode"> >- <option value="*">All</option> >+ <option value="*">All patron categories</option> > [% FOREACH patron_category IN patron_categories %] > <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option> > [% END %] >@@ -1072,7 +1072,7 @@ > <tr> > <td> > [% IF c == undef %] >- <em>All</em> >+ <em>All patron categories</em> > [% ELSE %] > [% Categories.GetName(c) | html %] > [% END %] >@@ -1093,7 +1093,7 @@ > <tr> > <td> > <select name="article_request_fee_category" id="article_request_fee_category"> >- <option value="*">All</option> >+ <option value="*">All patron categories</option> > [% FOREACH patron_category IN patron_categories %] > <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >index 774f7b74bc7..f88913b21b9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt >@@ -75,7 +75,7 @@ > <label for="categorycode" class="required">Patron category: </label> > <select name="categorycode" id="categorycode" required="required"> > <option value=""> Choose</option> >- <option value="*" selected="selected">All</option> >+ <option value="*" selected="selected">All patron categories</option> > [% FOREACH category IN categories %] > <option value="[% category.categorycode | html %]"> [% category.description | html %]</option> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31736
:
153301
|
153302
|
162545
|
163817
|
163859
|
163860
|
163861
|
163862
|
163863
|
163864
|
163865
|
163866
|
163867
|
163868
|
163869
|
163870
|
163871
|
169498
|
170072
|
170281
|
170282
|
170283
|
170284
|
170285
|
170286
|
170287
|
170288
|
170289
|
170290
|
170291
|
170292
|
170293
|
179845
|
179846
|
179847
|
179848
|
179849
|
179850
|
179851
|
179852
|
179853
|
179854
|
179855
|
179856
|
179857
|
188239
|
188240
|
188241
|
188242
|
188243
|
188244
|
188245
|
188246
|
188247
|
188248
|
188249
|
188250
|
188251
|
195143
|
195144
|
195145
|
195146
|
195147
|
195148
|
195149
|
195150
|
195151
|
195152
|
195153
|
195154
|
195155
|
195169
| 195170 |
195171
|
195172
|
195173
|
195174
|
195175
|
195176
|
195177
|
195178
|
195179
|
195180
|
195181
|
195182