Bugzilla – Attachment 195209 Details for
Bug 40879
Add system preference to enable/disable the “Cite” option in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40879: (follow-up) Change OpacCiteModal to OPACCite
Bug-40879-follow-up-Change-OpacCiteModal-to-OPACCi.patch (text/plain), 5.30 KB, created by
David Nind
on 2026-03-12 19:41:29 UTC
(
hide
)
Description:
Bug 40879: (follow-up) Change OpacCiteModal to OPACCite
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-03-12 19:41:29 UTC
Size:
5.30 KB
patch
obsolete
>From 3bbd3149e659946140abd0a683b8b965eb7459bc Mon Sep 17 00:00:00 2001 >From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Date: Mon, 1 Dec 2025 16:13:05 -0500 >Subject: [PATCH] Bug 40879: (follow-up) Change OpacCiteModal to OPACCite > >This patch addresses QA comments on the new system preference >name and description. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >--- > installer/data/mysql/atomicupdate/bug_40879.pl | 4 ++-- > installer/data/mysql/mandatory/sysprefs.sql | 2 +- > .../prog/en/modules/admin/preferences/opac.pref | 8 ++++---- > .../bootstrap/en/includes/modals/catalog_cite.inc | 2 +- > .../bootstrap/en/includes/opac-detail-sidebar.inc | 2 +- > 5 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_40879.pl b/installer/data/mysql/atomicupdate/bug_40879.pl >index 26649b4c18..ffb8e4c46f 100644 >--- a/installer/data/mysql/atomicupdate/bug_40879.pl >+++ b/installer/data/mysql/atomicupdate/bug_40879.pl >@@ -10,11 +10,11 @@ return { > > # Do you stuffs here > $dbh->do( >- q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('OpacCiteModal', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo')} >+ q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('OPACCite', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo')} > ); > > # sysprefs >- say $out "Added new system preference 'OpacCiteModal'"; >+ say $out "Added new system preference 'OPACCite'"; > > }, > }; >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index ba135461d5..007fd799c6 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -501,7 +501,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('OpacBrowseResults','1',NULL,'Disable/enable browsing and paging search results from the OPAC detail page.','YesNo'), > ('OpacBrowseSearch', '0',NULL, 'Elasticsearch only: add a page allowing users to \'browse\' all items in the collection','YesNo'), > ('OpacCatalogConcerns', '0', NULL, 'Allow logged in OPAC users to report catalog concerns', 'YesNo'), >-('OpacCiteModal', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo'), >+('OPACCite', '1', NULL, 'Enable or disable the Cite option in the OPAC record view.', 'YesNo'), > ('OpacCloud','0',NULL,'If ON, enables subject cloud on OPAC','YesNo'), > ('OpacCoce','0', NULL, 'If on, enables cover retrieval from the configured Coce server in the OPAC', 'YesNo'), > ('OPACComments','1',NULL,'If ON, enables patron reviews of bibliographic records in the OPAC','YesNo'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >index d2834773e7..6abb875fd5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref >@@ -427,11 +427,11 @@ OPAC: > - "patrons to browse subject authorities on the OPAC." > - "<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/build_browser_and_cloud.pl</code> cronjob. Ask your system administrator to schedule it." > - >- - pref: OpacCiteModal >+ - pref: OPACCite > choices: >- 1: Enable >- 0: Disable >- - the option to show the Cite modal on the bibliographic detail page. >+ 1: Show >+ 0: "Don't show" >+ - the cite option on OPAC bibliographic detail pages. > - > - pref: OpacCloud > choices: >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc >index 15895d18bd..b80efac826 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/modals/catalog_cite.inc >@@ -1,5 +1,5 @@ > [% USE raw %] >-[% IF Koha.Preference('OpacCiteModal') %] >+[% IF Koha.Preference('OPACCite') %] > <!-- Add cite modal --> > <div class="modal" id="citeModal" tabindex="-1" role="dialog" aria-labelledby="citeLabel" aria-hidden="true"> > <div class="modal-dialog modal-lg"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >index c8f51b1f43..06e9f42677 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc >@@ -22,7 +22,7 @@ > <li > ><a class="print-large btn btn-link btn-lg" href="#"><i class="fa fa-fw fa-print" aria-hidden="true"></i> Print</a></li > > >- [% IF Koha.Preference('OpacCiteModal') %] >+ [% IF Koha.Preference('OPACCite') %] > <li > ><a class="cite btn btn-link btn-lg" href="#" id="cite" data-bs-toggle="modal" data-bs-target="#citeModal"><i class="fa fa-fw fa-quote-left" aria-hidden="true"></i> Cite</a></li > > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40879
:
186928
|
186929
|
186930
|
186931
|
186932
|
186933
|
186935
|
186936
|
186937
|
186938
|
186939
|
186940
|
186941
|
190032
|
190033
|
190034
|
190035
|
190036
|
190065
|
190087
|
190088
|
190089
|
190090
|
190091
|
190092
|
194902
|
195185
|
195186
|
195187
|
195188
|
195189
|
195190
|
195191
|
195204
|
195205
|
195206
|
195207
|
195208
|
195209
|
195210
|
195211
|
195212
|
195213
|
195214
|
195215
|
195216
|
195217