Bugzilla – Attachment 195381 Details for
Bug 42102
Z39.50 ISBN sometimes fails when right truncation provided
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 42102: Try with and without right truncation for ISBN
Bug-42102-Try-with-and-without-right-truncation-fo.patch (text/plain), 1.60 KB, created by
David Cook
on 2026-03-16 03:39:35 UTC
(
hide
)
Description:
Bug 42102: Try with and without right truncation for ISBN
Filename:
MIME Type:
Creator:
David Cook
Created:
2026-03-16 03:39:35 UTC
Size:
1.60 KB
patch
obsolete
>From aaee6dcad9e3beccee59dfc993abef3a3d01ae36 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 16 Mar 2026 03:36:11 +0000 >Subject: [PATCH] Bug 42102: Try with and without right truncation for ISBN > >This change widens the ISBN search to try with and without right >truncation as different Z39.50 servers appear to handle this >differently. Some will ignore it and others will fail to return >a result if a full ISBN is provided (like with the Library of Congress >currently) > >Test plan: >0. Do not apply the patch yet >1. Log into koha-testing-docker >2. Do a ISBN search for 9780879933913 for the Library of Congress >(Note to use the Z39.50 and NOT the SRU) >3. Note that it doesn't return any results > >4. Apply the patch and koha-plack --restart kohadev > >5. Do a ISBN search for 9780879933913 for the Library of Congress >(Note to use the Z39.50 and NOT the SRU) >6. Note that you get a result >7. Do a ISBN search for 978087993391 for the Library of Congress >8. Note that you get a result with the partial ISBN >--- > C4/Breeding.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Breeding.pm b/C4/Breeding.pm >index bdabd8828ac..cf7787053be 100644 >--- a/C4/Breeding.pm >+++ b/C4/Breeding.pm >@@ -253,7 +253,7 @@ sub _bib_build_query { > my ($pars) = @_; > > my $qry_build = { >- isbn => '@attr 1=7 @attr 5=1 "#term" ', >+ isbn => '@or @attr 1=7 "#term" @attr 1=7 @attr 5=1 "#term" ', > issn => '@attr 1=8 @attr 5=1 "#term" ', > title => '@attr 1=4 "#term" ', > author => '@attr 1=1003 "#term" ', >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 42102
:
195381
|
195382