Bugzilla – Attachment 19600 Details for
Bug 10527
C4::Branch::get_branch_code_from_name is useless
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10527: C4::Branch::get_branch_code_from_name is useless
Bug-10527-C4Branchgetbranchcodefromname-is-useless.patch (text/plain), 3.50 KB, created by
Kyle M Hall (khall)
on 2013-07-12 15:11:06 UTC
(
hide
)
Description:
Bug 10527: C4::Branch::get_branch_code_from_name is useless
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-07-12 15:11:06 UTC
Size:
3.50 KB
patch
obsolete
>From dcf554a445adbedc0c6f093926492751e56599a1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 2 Jul 2013 12:56:21 +0200 >Subject: [PATCH] Bug 10527: C4::Branch::get_branch_code_from_name is useless > >This routine is not in used and does not make sense. It should not be >used later. > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Passes koha-qa.pl, not references to get_branch_code_from_name found. >--- > C4/Branch.pm | 11 +---------- > labels/label-edit-batch.pl | 1 - > labels/label-manage.pl | 1 - > patroncards/edit-batch.pl | 1 - > patroncards/manage.pl | 1 - > tools/manage-marc-import.pl | 1 - > 6 files changed, 1 insertions(+), 15 deletions(-) > >diff --git a/C4/Branch.pm b/C4/Branch.pm >index 5770f7b..b1e66be 100644 >--- a/C4/Branch.pm >+++ b/C4/Branch.pm >@@ -48,7 +48,7 @@ BEGIN { > &mybranch > &GetBranchesCount > ); >- @EXPORT_OK = qw( &onlymine &mybranch get_branch_code_from_name ); >+ @EXPORT_OK = qw( &onlymine &mybranch ); > } > > =head1 NAME >@@ -589,15 +589,6 @@ sub CheckBranchCategorycode { > return $total; > } > >-sub get_branch_code_from_name { >- my @branch_name = @_; >- my $query = "SELECT branchcode FROM branches WHERE branchname=?;"; >- my $dbh = C4::Context->dbh(); >- my $sth = $dbh->prepare($query); >- $sth->execute(@branch_name); >- return $sth->fetchrow_array; >-} >- > sub GetBranchesCount { > my $dbh = C4::Context->dbh(); > my $query = "SELECT COUNT(*) AS branches_count FROM branches"; >diff --git a/labels/label-edit-batch.pl b/labels/label-edit-batch.pl >index d534b87..aea4742 100755 >--- a/labels/label-edit-batch.pl >+++ b/labels/label-edit-batch.pl >@@ -26,7 +26,6 @@ use CGI; > > use C4::Auth qw(get_template_and_user); > use C4::Output qw(output_html_with_http_headers); >-use C4::Branch qw(get_branch_code_from_name); > use C4::Items qw(GetItemnumberFromBarcode); > use C4::Creators; > use C4::Labels; >diff --git a/labels/label-manage.pl b/labels/label-manage.pl >index 7ef3300..871780d 100755 >--- a/labels/label-manage.pl >+++ b/labels/label-manage.pl >@@ -27,7 +27,6 @@ use Data::Dumper; > > use C4::Auth qw(get_template_and_user); > use C4::Output qw(output_html_with_http_headers); >-use autouse 'C4::Branch' => qw(get_branch_code_from_name); > use C4::Creators; > use C4::Labels; > >diff --git a/patroncards/edit-batch.pl b/patroncards/edit-batch.pl >index 4897e5f..497c01c 100755 >--- a/patroncards/edit-batch.pl >+++ b/patroncards/edit-batch.pl >@@ -27,7 +27,6 @@ use autouse 'Data::Dumper' => qw(Dumper); > > use C4::Auth qw(get_template_and_user); > use C4::Output qw(output_html_with_http_headers); >-use C4::Branch qw(get_branch_code_from_name); > use C4::Creators; > use C4::Patroncards; > >diff --git a/patroncards/manage.pl b/patroncards/manage.pl >index d052f67..2af8c0e 100755 >--- a/patroncards/manage.pl >+++ b/patroncards/manage.pl >@@ -27,7 +27,6 @@ use autouse 'Data::Dumper' => qw(Dumper); > > use C4::Auth qw(get_template_and_user); > use C4::Output qw(output_html_with_http_headers); >-use autouse 'C4::Branch' => qw(get_branch_code_from_name); > use C4::Creators; > use C4::Patroncards; > use C4::Labels; >diff --git a/tools/manage-marc-import.pl b/tools/manage-marc-import.pl >index 25f7769..c0584c9 100755 >--- a/tools/manage-marc-import.pl >+++ b/tools/manage-marc-import.pl >@@ -36,7 +36,6 @@ use C4::ImportBatch; > use C4::Matcher; > use C4::BackgroundJob; > use C4::Labels::Batch; >-use C4::Branch qw(get_branch_code_from_name); > > my $script_name = "/cgi-bin/koha/tools/manage-marc-import.pl"; > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10527
:
19334
|
19511
| 19600