Bugzilla – Attachment 19609 Details for
Bug 10529
Dollar sign hardcoded in patron message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10529: Remove hardcoded dollar from patron message
Bug-10529-Remove-hardcoded-dollar-from-patron-mess.patch (text/plain), 1.73 KB, created by
Kyle M Hall (khall)
on 2013-07-12 17:16:22 UTC
(
hide
)
Description:
Bug 10529: Remove hardcoded dollar from patron message
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-07-12 17:16:22 UTC
Size:
1.73 KB
patch
obsolete
>From 3e74c994d8f3a07adadc8fed8800c38293e80150 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 4 Jul 2013 12:21:45 +0100 >Subject: [PATCH] Bug 10529: Remove hardcoded dollar from patron message > >The message fields which are returned in the SIP >Screen message field in a Patron Information response >had dollar hardcoded. >It would be possible to get the symbol from currency >but omitting any symbol would be consistent with the UI >and avoid problems with devices using weird encodings >for local currency symbols (e.g. the many variations >of UK Pound sign) > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Members.pm | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index 3221f53..6d8d23a 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -435,7 +435,7 @@ sub patronflags { > if ( $owing > 0 ) { > my %flaginfo; > my $noissuescharge = C4::Context->preference("noissuescharge") || 5; >- $flaginfo{'message'} = sprintf "Patron owes \$%.02f", $owing; >+ $flaginfo{'message'} = sprintf 'Patron owes %.02f', $owing; > $flaginfo{'amount'} = sprintf "%.02f", $owing; > if ( $owing > $noissuescharge && !C4::Context->preference("AllowFineOverride") ) { > $flaginfo{'noissues'} = 1; >@@ -444,7 +444,7 @@ sub patronflags { > } > elsif ( $balance < 0 ) { > my %flaginfo; >- $flaginfo{'message'} = sprintf "Patron has credit of \$%.02f", -$balance; >+ $flaginfo{'message'} = sprintf 'Patron has credit of %.02f', -$balance; > $flaginfo{'amount'} = sprintf "%.02f", $balance; > $flags{'CREDITS'} = \%flaginfo; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10529
:
19396
|
19445
| 19609