Bugzilla – Attachment 19629 Details for
Bug 9770
C4::ClassSortRoutine::Dewey can pad the wrong part of a call number internally
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 9770: test case for sorting of Dewey call numbers that contain prefixes
PASSED-QA-Bug-9770-test-case-for-sorting-of-Dewey-.patch (text/plain), 1.60 KB, created by
Katrin Fischer
on 2013-07-14 12:12:58 UTC
(
hide
)
Description:
[PASSED QA] Bug 9770: test case for sorting of Dewey call numbers that contain prefixes
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-07-14 12:12:58 UTC
Size:
1.60 KB
patch
obsolete
>From 2703c92610ae064407675393f7dbb9b69174a12b Mon Sep 17 00:00:00 2001 >From: Jason Etheridge <jason@esilibrary.com> >Date: Fri, 21 Jun 2013 15:31:32 -0400 >Subject: [PATCH] [PASSED QA] Bug 9770: test case for sorting of Dewey call > numbers that contain prefixes > >This adds a test for C4::ClassSortRoutine::Dewey to check that the >call number "JR DVD 800.1" sorts before "JR DVD 900" > >To test: > >[1] Apply just this patch. >[1] Run prove -v t/ClassSortRoutine_Dewey.t >[2] Test #7 should fail. > >Signed-off-by: Jason Etheridge <jason@esilibrary.com> >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes test plan and QA script. >--- > t/ClassSortRoutine_Dewey.t | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/t/ClassSortRoutine_Dewey.t b/t/ClassSortRoutine_Dewey.t >index 7a4d7f4..ae3549e 100755 >--- a/t/ClassSortRoutine_Dewey.t >+++ b/t/ClassSortRoutine_Dewey.t >@@ -6,7 +6,7 @@ > use strict; > use warnings; > >-use Test::More tests => 6; >+use Test::More tests => 7; > > BEGIN { > use_ok('C4::ClassSortRoutine::Dewey'); >@@ -26,3 +26,7 @@ is($cn_sort,"ABC_123_456000000000000","testing alphanumeric"); > > $cn_sort = C4::ClassSortRoutine::Dewey::get_class_sort_key("ab c123","45 6"); > is($cn_sort,"AB_C123_45_600000000000000","testing middle whitespace"); >+ >+$cn_sort = C4::ClassSortRoutine::Dewey::get_class_sort_key("YR DVD 800.1",""); >+my $cn_sort2 = C4::ClassSortRoutine::Dewey::get_class_sort_key("YR DVD 900",""); >+ok( $cn_sort lt $cn_sort2, "testing prefix plus decimal" ); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9770
:
15977
|
19195
|
19383
|
19384
|
19385
|
19386
|
19387
| 19629 |
19630