Bugzilla – Attachment 19649 Details for
Bug 10258
Remove erroneous call to haspermission in basket.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10258: offer to create basket group only when staff user has correct permission
Bug-10258-offer-to-create-basket-group-only-when-s.patch (text/plain), 2.34 KB, created by
Marcel de Rooy
on 2013-07-15 11:59:09 UTC
(
hide
)
Description:
Bug 10258: offer to create basket group only when staff user has correct permission
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-07-15 11:59:09 UTC
Size:
2.34 KB
patch
obsolete
>From 596da16af18d94500cde4489ae388e46a9009560 Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Sun, 16 Jun 2013 18:05:31 -0700 >Subject: [PATCH] Bug 10258: offer to create basket group only when staff user > has correct permission >Content-Type: text/plain; charset=utf-8 > >If the staff user does not have the group_manage acquisition permission, >do not offer to create a new basket group when closing an order basket. > >This avoids a situation where if a staff member without that permission tries >to close a basket and chose the option to create a bakset group, they would >be redirected to the login page. > >To test: > >[1] Log in as a staff user that does not have > the acquisition/group_manage permission. >[2] Create a new order basket, attach at least one > order line to it, then close it. >[3] Verify that the confirmation page does not > offer to create a basket group with the > same name as the order basket. >[4] Log in as a staff user that has the > acquisition/group_manage permission. >[5] Create and close an order basket. >[6] Verify that this time, the confirmation page > *does* offer to create a basket group. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 7f9ee31..84df886 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -462,10 +462,12 @@ > > <form action="/cgi-bin/koha/acqui/basket.pl" class="confirm"> > <h1>Are you sure you want to close basket [% basketname|html %]?</h1> >+ [% IF ( CAN_user_acquisition_group_manage ) %] > <p> > <label for="createbasketgroup">Attach this basket to a new basket group with the same name</label> > <input type="checkbox" id="createbasketgroup" name="createbasketgroup"/> > </p> >+ [% END %] > <input type="hidden" id="basketno" value="[% basketno %]" name="basketno" /> > <input type="hidden" value="close" name="op" /> > <input type="hidden" name="booksellerid" value="[% booksellerid %]" /> >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10258
:
18166
|
18592
|
18736
|
18853
|
18944
|
19039
|
19053
|
19054
|
19648
| 19649