Attachment 19760 Details for Bug 10597 – Bug 10597 - Search to hold button broken on record details

[patch] Bug 10597 - Search to hold button broken on record details

Bug-10597---Search-to-hold-button-broken-on-record.patch (text/plain), 2.96 KB, created by Jonathan Druart on 2013-07-18 11:56:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-07-18 11:56:51 UTC

Size: 2.96 KB

patch

obsolete

>From b25d977785b8c8ab7b0bed13dda3a004ee77a678 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 16 Jul 2013 12:50:25 -0400
>Subject: [PATCH] Bug 10597 - Search to hold button broken on record details
>
>The holds button in cat-toolbar is broken for "search to hold". It is a
>split button rather than a dropdown button. Clicking the caret works
>fine, but clicked the button sends you to the marc editor!
>
>Test Plan:
>1) View a patron's details page
>2) Click 'search to hold'
>3) Search for something
>4) On the results page, click a result line's title link (
>    catalogue/detail.pl )
>5) Note the "Place hold" button is a split button, click the left half
>    of the button, note it redirects you to the editor.
>6) Apply this patch
>7) Repeat steps 1-5
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> .../intranet-tmpl/prog/en/includes/cat-toolbar.inc    |   17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>index 3683ac9..553d9ae 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc
>@@ -204,14 +204,15 @@ CAN_user_serials_create_subscription ) %]
>     [% UNLESS ( norequests ) %]
>         [% IF ( holdfor ) %]
>             <div class="btn-group">
>-            <button class="btn btn-small"><i class="icon-hold"></i> Place hold</button>
>-            <button class="btn btn-small dropdown-toggle" data-toggle="dropdown">
>-                <span class="caret"></span>
>-            </button>
>-            <ul class="dropdown-menu">
>-                <li><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]">Place hold</a></li>
>-                <li><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]&amp;findborrower=[% holdfor_cardnumber %]">Place hold for [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])</a></li>
>-            </ul>
>+                <button class="btn btn-small dropdown-toggle" data-toggle="dropdown">
>+                    <i class="icon-hold"></i>
>+                    Place hold
>+                    <span class="caret"></span>
>+                </button>
>+                <ul class="dropdown-menu">
>+                    <li><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]">Place hold</a></li>
>+                    <li><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]&amp;findborrower=[% holdfor_cardnumber %]">Place hold for [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])</a></li>
>+                </ul>
>             </div>
>         [% ELSE %]
>             <div class="btn-group"><a id="placehold" class="btn btn-small" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblionumber %]"><i class="icon-hold"></i> Place hold</a></div>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10597: 19696 | 19702 | 19760