Bugzilla – Attachment 19777 Details for
Bug 7442
Crash when selecting an authority with 200$x or 200$y
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7442 - Follow up : Authorities search on all types does not show summary
0002-Bug-7442-Follow-up-Authorities-search-on-all-types-d.patch (text/plain), 2.30 KB, created by
Fridolin Somers
on 2013-07-18 16:30:24 UTC
(
hide
)
Description:
Bug 7442 - Follow up : Authorities search on all types does not show summary
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2013-07-18 16:30:24 UTC
Size:
2.30 KB
patch
obsolete
>From 52d3253b4e7fa3fc5ec743ee08132d87003f86e1 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Thu, 18 Jul 2013 18:13:12 +0200 >Subject: [PATCH 2/2] Bug 7442 - Follow up : Authorities search on all types > does not show summary > >This patch corrects a small bug : >Authorities search on all types does not show summary because it is computed with selected type (which is empty) instead of using found authority type. > >Test plan : >- Go to intranet autorities search >- Perform a search on all authorities types >- Look at results >=> Without this patch, results rows do not display the autority summary, only authorized headings >--- > C4/AuthoritiesMarc.pm | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index 26f13ac..a004918 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -274,8 +274,6 @@ sub SearchAuthorities { > my %newline; > $newline{authid} = $authid; > if ( !$skipmetadata ) { >- my $summary = >- BuildSummary( $authrecord, $authid, $authtypecode ); > my $query_auth_tag = > "SELECT auth_tag_to_report FROM auth_types WHERE authtypecode=?"; > my $sth = $dbh->prepare($query_auth_tag); >@@ -284,15 +282,18 @@ sub SearchAuthorities { > my $reported_tag; > my $mainentry = $authrecord->field($auth_tag_to_report); > if ($mainentry) { >- > foreach ( $mainentry->subfields() ) { > $reported_tag .= '$' . $_->[0] . $_->[1]; > } > } >- my $thisauthtype = GetAuthType(GetAuthTypeCode($authid)); >+ my $thisauthtypecode = GetAuthTypeCode($authid); >+ my $thisauthtype = GetAuthType($thisauthtypecode); > unless (defined $thisauthtype) { >- $thisauthtype = GetAuthType($authtypecode) if $authtypecode; >+ $thisauthtypecode = $authtypecode; >+ $thisauthtype = GetAuthType($authtypecode); > } >+ my $summary = BuildSummary( $authrecord, $authid, $thisauthtypecode ); >+ > $newline{authtype} = defined($thisauthtype) ? > $thisauthtype->{'authtypetext'} : ''; > $newline{summary} = $summary; >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7442
:
7133
|
7135
|
9410
|
19776
|
19777
|
19778
|
19779
|
23152
|
23153