Bugzilla – Attachment 19856 Details for
Bug 10557
GetBooksellersWithLateOrders has an unused branch parameter
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter
PASSED-QA-Bug-10557-GetBooksellersWithLateOrders-h.patch (text/plain), 1.96 KB, created by
Katrin Fischer
on 2013-07-22 17:36:12 UTC
(
hide
)
Description:
[PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-07-22 17:36:12 UTC
Size:
1.96 KB
patch
obsolete
>From 575d9e0098f0f63588e81e761fbdfba284a8b553 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Tue, 9 Jul 2013 12:02:00 +0200 >Subject: [PATCH] [PASSED QA] Bug 10557: GetBooksellersWithLateOrders has an > unused branch parameter > >C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. >The $branch variable is never used in the routine. > >Test plan: >Check that no behavior changes on the late orders page. > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >I couldn't find any use of the branch parameter apart from >the one corrected by this patch. Also tested late orders, >couldn't find any problems. >--- > C4/Bookseller.pm | 4 ++-- > acqui/lateorders.pl | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm >index 007cfce..4426368 100644 >--- a/C4/Bookseller.pm >+++ b/C4/Bookseller.pm >@@ -100,14 +100,14 @@ sub GetBookSellerFromId { > > =head2 GetBooksellersWithLateOrders > >-%results = GetBooksellersWithLateOrders($delay); >+%results = GetBooksellersWithLateOrders( $delay, $estimateddeliverydatefrom, $estimateddeliverydateto ); > > Searches for suppliers with late orders. > > =cut > > sub GetBooksellersWithLateOrders { >- my ( $delay, $branch, $estimateddeliverydatefrom, $estimateddeliverydateto ) = @_; # FIXME: Branch argument unused. >+ my ( $delay, $estimateddeliverydatefrom, $estimateddeliverydateto ) = @_; > my $dbh = C4::Context->dbh; > > # FIXME NOT quite sure that this operation is valid for DBMs different from Mysql, HOPING so >diff --git a/acqui/lateorders.pl b/acqui/lateorders.pl >index 7c2b3f3..d732357 100755 >--- a/acqui/lateorders.pl >+++ b/acqui/lateorders.pl >@@ -118,7 +118,7 @@ if ($op and $op eq "send_alert"){ > } > } > >-my @parameters = ( $delay, $branch ); >+my @parameters = ( $delay ); > push @parameters, $estimateddeliverydatefrom_dt > ? $estimateddeliverydatefrom_dt->ymd() > : undef; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10557
:
19499
|
19699
| 19856