Bugzilla – Attachment 19898 Details for
Bug 9394
Use reserve_id where possible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9394: (follow-up) fix query column alias
Bug-9394-follow-up-fix-query-column-alias.patch (text/plain), 1.33 KB, created by
Galen Charlton
on 2013-07-23 22:22:31 UTC
(
hide
)
Description:
Bug 9394: (follow-up) fix query column alias
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2013-07-23 22:22:31 UTC
Size:
1.33 KB
patch
obsolete
>From 908d43ffd31b7a506ddbde3b2d27032333cc06e1 Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Tue, 23 Jul 2013 21:06:30 +0000 >Subject: [PATCH] Bug 9394: (follow-up) fix query column alias > >A change-and-replace went a tick too far. This patch >adjusts the column alias in the query run in MergeHolds() >to reflect that the value being returned is the number of >hold requests, not an ID. > >To test: > >[1] This patch should have no visible changes to behavior. To > verify, pick to bib records that have hold requests on them, > then merge them together. Verify that the merged bib > contains sll of the hold requests on it. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >--- > C4/Reserves.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 13787fc..7f95a26 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -2014,7 +2014,7 @@ This shifts the holds from C<$from_biblio> to C<$to_biblio> and reorders them by > sub MergeHolds { > my ( $dbh, $to_biblio, $from_biblio ) = @_; > my $sth = $dbh->prepare( >- "SELECT count(*) as reserve_id FROM reserves WHERE biblionumber = ?" >+ "SELECT count(*) as reserve_count FROM reserves WHERE biblionumber = ?" > ); > $sth->execute($from_biblio); > if ( my $data = $sth->fetchrow_hashref() ) { >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9394
:
14601
|
14860
|
14863
|
15730
|
15733
|
16676
|
17447
|
18216
|
18318
|
18465
|
18466
|
18492
|
18621
|
19893
|
19894
|
19895
|
19896
|
19897
|
19898
|
19899
|
19902
|
19904
|
19905
|
19906
|
19907
|
19908
|
19909