Bugzilla – Attachment 19900 Details for
Bug 10508
UT: C4::Branch.pm needs unit tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] C4::Branch.pm needs unit tests
SIGNED-OFF-C4Branchpm-needs-unit-tests.patch (text/plain), 1.55 KB, created by
Srdjan Jankovic
on 2013-07-24 03:12:34 UTC
(
hide
)
Description:
[SIGNED-OFF] C4::Branch.pm needs unit tests
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2013-07-24 03:12:34 UTC
Size:
1.55 KB
patch
obsolete
>From 745cccd159c20123fdbbde91e3b22ed41a12d0ec Mon Sep 17 00:00:00 2001 >From: Kenza Zaki <kenza.zaki@biblibre.com> >Date: Tue, 23 Jul 2013 14:58:39 +0200 >Subject: [PATCH] [SIGNED-OFF] C4::Branch.pm needs unit tests > >Unit tests are wrap in a transaction. > >To test: >prove t/db_dependent/Branch.t >t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207. >t/db_dependent/Branch.t .. ok >All tests successful. >Files=1, Tests=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) >Result: PASS > >http://bugs.koha-community.org/show_bug.cgi?id=10508 >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >--- > t/db_dependent/Branch.t | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Branch.t b/t/db_dependent/Branch.t >index 4251816..ffa2346 100644 >--- a/t/db_dependent/Branch.t >+++ b/t/db_dependent/Branch.t >@@ -21,7 +21,7 @@ use Modern::Perl; > use C4::Context; > use Data::Dumper; > >-use Test::More ;#tests => 6; >+use Test::More tests => 36; > > use C4::Branch; > >@@ -161,7 +161,7 @@ is( GetBranchesCount, $count + 1, > "A branch has been modified, no new branch added" ); > $branchdetail = GetBranchDetail( $b1->{branchcode} ); > $b1->{issuing} = undef; >-is_deeply( $branchdetail, $b1 ); >+is_deeply( $branchdetail, $b1 , "GetBranchDetail gives the details of BRA"); > > #Test categories > my $categories = GetBranchCategories; >@@ -350,4 +350,3 @@ is( scalar(@$loop), GetBranchesCount, 'There is the right number of branches' ); > # End transaction > $dbh->rollback; > >-done_testing; >-- >1.8.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10508
:
19338
|
19546
|
19687
|
19688
|
19771
|
19780
|
19781
|
19853
|
19864
|
19900
|
20029
|
20626
|
20638
|
20639
|
20663
|
20664