Bugzilla – Attachment 19935 Details for
Bug 9032
Share a list
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9032 [Template follow-up] Share a list (part 1: send the invitation)
Bug-9032-Template-follow-up-Share-a-list-part-1-se.patch (text/plain), 3.56 KB, created by
Marcel de Rooy
on 2013-07-25 07:29:24 UTC
(
hide
)
Description:
Bug 9032 [Template follow-up] Share a list (part 1: send the invitation)
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-07-25 07:29:24 UTC
Size:
3.56 KB
patch
obsolete
>From 97d780823420fe55ca2d812a6c2d1da8e769bf45 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 5 Jun 2013 12:22:02 -0400 >Subject: [PATCH] Bug 9032 [Template follow-up] Share a list (part 1: send the > invitation) >Content-Type: text/plain; charset=utf-8 > >This patch makes a few changes to the "share a list" template: > >- We don't use tables for layout of forms. This patch corrects the > display of the share form to use Koha standard form markup. >- Revise the confirmation message displayed after a list is shared to be > more readable. >- Add a link back to private lists to the confirmation message. >- Add T:T markup to make this page display the left-hand navigation > which is shown on other patron-related pages when a user is logged in. > >To test, apply this patch on top of other patches pending for Bug 9032 >and confirm that the list share form looks correct and works correctly. >Confirm that share confirmation page reads well. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../opac-tmpl/prog/en/modules/opac-shareshelf.tt | 34 ++++++++++---------- > 1 files changed, 17 insertions(+), 17 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shareshelf.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shareshelf.tt >index 63c17bc..9adebcc 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-shareshelf.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-shareshelf.tt >@@ -24,25 +24,25 @@ > <form method="post" onsubmit="return $('#invite_address').val().trim()!='';"> > <input type="hidden" name="op" value="conf_invite"/> > <input type="hidden" name="shelfnumber" value="[% shelfnumber %]"/> >- <table> >- <tr> >- <td><label for="list_name">List name</label></td> >- <td>[% shelfname %]</td> >- </tr> >- <tr> >- <td><label for="invite_address">Email address</label></td> >- <td><input id="invite_address" name="invite_address"/></td> >- </tr> >- </table> >- <input type="submit" value="Send"/> >+ <fieldset class="rows"> >+ <ol> >+ <li><span class="label">List name:</span> [% shelfname %]</li> >+ <li><label for="invite_address">Email address:</label> <input id="invite_address" name="invite_address"/></li> >+ </ol> >+ </fieldset> >+ >+ <fieldset class="action"> >+ <input type="submit" value="Send" /> >+ </fieldset> > </form> > > [% ELSIF op=='conf_invite' %] >- <p>We have sent invitation emails to share list [% shelfname %] to the mail queue for [% approvedaddress %].</p> >+ <p>An invitation to share list <i>[% shelfname %]</i> has been sent to [% approvedaddress %].</p> > [% IF failaddress %] > <p>The following addresses appear to be invalid. Please correct them and try again. These are: [% failaddress %]</p> > [% END %] > <p>You will be notified if someone accepts your share within two weeks.</p> >+ <p><a href="/cgi-bin/koha/opac-shelves.pl?display=privateshelves">Return to your lists</a></p> > > [% ELSIF op=='accept' %] > [%# TODO: Replace the following two lines %] >@@ -57,11 +57,11 @@ > </div> > > [% IF ( OpacNav ) %] >- <div class="yui-b"> >- <div id="opacnav" class="container"> >- [% INCLUDE 'navigation.inc' %] >- </div> >- </div> >+ <div class="yui-b"> >+ <div id="leftmenus" class="container"> >+ [% INCLUDE 'navigation.inc' IsPatronPage=1 %] >+ </div> >+ </div> > [% END %] > > </div> >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9032
:
18260
|
18542
|
18543
|
18546
|
18547
|
18587
|
18619
|
18682
|
18692
|
19377
|
19378
|
19379
|
19394
|
19934
|
19935
|
25847
|
25848
|
25849
|
25850
|
25851
|
25852
|
25853
|
25862
|
25886
|
25893
|
26253
|
26291
|
26292
|
26293
|
26294
|
26295
|
26296
|
26297
|
26298
|
26299
|
26300
|
26302
|
26303
|
26351
|
26458
|
26509
|
26513
|
26577
|
26578
|
26579
|
26580
|
26581
|
26582
|
26583
|
26584
|
26585
|
26586
|
26587
|
26588