Bugzilla – Attachment 19982 Details for
Bug 10543
false mandatory warning in additem
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10543 - add mandatory subfield check to addorderiso2709.pl
PASSED-QA-Bug-10543---add-mandatory-subfield-check.patch (text/plain), 3.03 KB, created by
Katrin Fischer
on 2013-07-29 21:10:30 UTC
(
hide
)
Description:
[PASSED QA] Bug 10543 - add mandatory subfield check to addorderiso2709.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-07-29 21:10:30 UTC
Size:
3.03 KB
patch
obsolete
>From 41309b766cf753b341dbe2df57a16dab989db207 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Thu, 11 Jul 2013 16:33:33 +0200 >Subject: [PATCH] [PASSED QA] Bug 10543 - add mandatory subfield check to > addorderiso2709.pl > >When adding orders from staged file, you can create one order per record using item form in the bottom of addorderiso2709.pl. >This form was missing check. > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> > >All 3 patches pass tests and QA script. > >Some additional notes on the test plan from the first patch: >It took me a while to figure out a combination of subfields >that would trigger the bug. I am not sure about the condition >that transforms the input field into a textbox as it does >not seem to happen for every field. > >What worked in the end was (MARC21): >- $g cost, normal purchase price = mandatory >- $h serial enumeration/chronolgy = optional, filled with > text over 100 characters > >Checked for: >- Adding items in cataloguing > Was able to reproduce the problem, mandatory check works > as expected. >- Adding items from staged file in acq > Was not able to trigger the problem, because we don't edit > the item here, but mandatory check works as expected. >- Addings items for serial subscriptions > Was not able to trigger the problem, because we don't edit > the items here, but mandatory check works better as before > as missing mandatory fields are now highlighted and weren't > before. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > .../prog/en/modules/acqui/addorderiso2709.tt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >index 3627077..3223dc2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >@@ -13,6 +13,7 @@ > [% INCLUDE 'datatables-strings.inc' %] > <script type="text/javascript" src="[% themelang %]/js/datatables.js"></script> > <script type="text/javascript" src="[% themelang %]/js/acq.js"></script> >+<script type="text/javascript" src="[% themelang %]/js/cataloging.js"></script> > <script type="text/JavaScript"> > //<![CDATA[ > [% IF (dateformat == 'metric') %] >@@ -25,6 +26,18 @@ > ], > "sPaginationType": "four_button" > } ) ); >+ >+ $("form#Aform").submit(function() { >+ var total_errors = CheckMandatorySubfields(this); >+ if (total_errors > 0) { >+ var alertString = _("Form not submitted because of the following problem(s)"); >+ alertString += "\n------------------------------------------------------------------------------------\n"; >+ alertString += "\n- "+ total_errors + _(" mandatory fields empty (highlighted)"); >+ alert(alertString); >+ return false; >+ } >+ return true; >+ }); > }); > //]]> > </script> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10543
:
19412
|
19572
|
19574
|
19576
|
19704
|
19705
|
19706
|
19980
|
19981
| 19982