Bugzilla – Attachment 19999 Details for
Bug 8769
Allow SIP2 return backdating
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8769 - Allow SIP2 return backdating
Bug-8769---Allow-SIP2-return-backdating.patch (text/plain), 2.58 KB, created by
Kyle M Hall (khall)
on 2013-07-31 09:43:14 UTC
(
hide
)
Description:
Bug 8769 - Allow SIP2 return backdating
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-07-31 09:43:14 UTC
Size:
2.58 KB
patch
obsolete
>From 73b909f98e9e34e9075595b3c80c818e48076958 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 30 Jul 2013 14:45:47 -0400 >Subject: [PATCH] Bug 8769 - Allow SIP2 return backdating > >Currently Koha's SIP server ignores the return date part of an 09 ( aka >CHECKIN ) message. Koha should backdate a return, and remove >fines accordingly. >--- > C4/Circulation.pm | 4 ++-- > C4/SIP/ILS.pm | 2 +- > C4/SIP/ILS/Transaction/Checkin.pm | 3 ++- > 3 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 352efde..8b5ac49 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1687,7 +1687,7 @@ patron who last borrowed the book. > =cut > > sub AddReturn { >- my ( $barcode, $branch, $exemptfine, $dropbox ) = @_; >+ my ( $barcode, $branch, $exemptfine, $dropbox, $return_date ) = @_; > > if ($branch and not GetBranchDetail($branch)) { > warn "AddReturn error: branch '$branch' not found. Reverting to " . C4::Context->userenv->{'branch'}; >@@ -1798,7 +1798,7 @@ sub AddReturn { > } > > MarkIssueReturned( $borrowernumber, $item->{'itemnumber'}, >- $circControlBranch, '', $borrower->{'privacy'} ); >+ $circControlBranch, $return_date, $borrower->{'privacy'} ); > > # FIXME is the "= 1" right? This could be the borrower hash. > $messages->{'WasReturned'} = 1; >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 5d59850..04aa884 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -181,7 +181,7 @@ sub checkin { > $circ->item($item = new ILS::Item $item_id); > > if ($item) { >- $circ->do_checkin($current_loc); >+ $circ->do_checkin($current_loc, $return_date); > } else { > $circ->alert(1); > $circ->alert_type(99); >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index 47bd85d..5c1cf04 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -47,12 +47,13 @@ sub new { > sub do_checkin { > my $self = shift; > my $branch = shift; >+ my $return_date = shift; > if (!$branch) { > $branch = 'SIP2'; > } > my $barcode = $self->{item}->id; > $debug and warn "do_checkin() calling AddReturn($barcode, $branch)"; >- my ($return, $messages, $iteminformation, $borrower) = AddReturn($barcode, $branch); >+ my ($return, $messages, $iteminformation, $borrower) = AddReturn($barcode, $branch, $return_date); > $self->alert(!$return); > # ignoring messages: NotIssued, IsPermanent, WasLost, WasTransfered > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8769
:
12193
|
12811
|
12812
|
12813
|
15248
|
19999
|
20000
|
21942
|
23698
|
26753
|
27465
|
27466
|
27467
|
27944
|
27945
|
27946