Bugzilla – Attachment 20104 Details for
Bug 10078
show location facet for all
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10078 - show location facet for all
Bug-10078---show-location-facet-for-all.patch (text/plain), 3.30 KB, created by
Srdjan Jankovic
on 2013-08-05 06:14:09 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10078 - show location facet for all
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2013-08-05 06:14:09 UTC
Size:
3.30 KB
patch
obsolete
>From 753a08b6c9327b738717fa1affbc73187a65bbbf Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 2 Jul 2013 16:40:43 +1000 >Subject: [PATCH] Bug 10078 - show location facet for all > >Currently, the location facet only shows if you have singlebranch >mode enabled. In other words, you can either see the library branch >or the shelving location. > >This patch simply changes the location facet so that it will always >show the shelving location (if one is available), regardless of the >singlebranch system preference. > >Test Plan: > >BEFORE APPLYING: > >0) Disable singlebranch mode if it is on >1) Do an OPAC or Staff Client search for a record that has items with >shelving locations. >2) Note that you can see the library branch facet under Libraries >but no shelving locations. >3) Enable singlebranch mode >4) Repeat your search >5) Note that you can no longer see the library branch facet under >Libraries. However, you can see the shelving location under Location > >N.B. If you don't have more than one branch or the search results >are all from one branch, you might not get a library branch facet. > >If this is the case, create additional branches and/or change the >branch for items in your search results so that you have multiple >branches to prompt the appearance of a library branch facet. > >AFTER APPLYING > >1) Do an OPAC or Staff Client search for a record that has items with >shelving locations. >2) Note that you see a facet under Location on the left sidebar, >regardless of there being a singlebranch mode or the number of branches >there are being represented in the search results. > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >--- > C4/Koha.pm | 22 ++++++++++------------ > 1 file changed, 10 insertions(+), 12 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index ea8c2a6..1021ef2 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -730,6 +730,11 @@ sub getFacets { > tags => [ qw/ 225a / ], > sep => ', ', > }, >+ { >+ idx => 'location', >+ label => 'Location', >+ tags => [ qw/ 995c / ], >+ } > ]; > > my $library_facet; >@@ -739,12 +744,6 @@ sub getFacets { > label => 'Libraries', > tags => [ qw/ 995b / ], > }; >- } else { >- $library_facet = { >- idx => 'location', >- label => 'Location', >- tags => [ qw/ 995c / ], >- }; > } > push( @$facets, $library_facet ); > } >@@ -792,6 +791,11 @@ sub getFacets { > tags => [ qw/ 952y 942c / ], > sep => ', ', > }, >+ { >+ idx => 'location', >+ label => 'Location', >+ tags => [ qw / 952c / ], >+ }, > ]; > > my $library_facet; >@@ -801,12 +805,6 @@ sub getFacets { > label => 'Libraries', > tags => [ qw / 952b / ], > }; >- } else { >- $library_facet = { >- idx => 'location', >- label => 'Location', >- tags => [ qw / 952c / ], >- }; > } > push( @$facets, $library_facet ); > } >-- >1.8.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10078
:
19331
|
20104
|
20398