Attachment 20227 Details for Bug 10305 – Bug 10305 - _increment_barcode is called twice

[patch] Bug 10305 - _increment_barcode is called twice

Bug-10305---incrementbarcode-is-called-twice.patch (text/plain), 1.14 KB, created by Kyle M Hall (khall) on 2013-08-09 13:25:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-08-09 13:25:26 UTC

Size: 1.14 KB

patch

obsolete

>From 2f9f48887ec1647eb4559d868d423b96597ae862 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 21 May 2013 15:58:44 -0400
>Subject: [PATCH] Bug 10305 - _increment_barcode is called twice
>
>For some reason, _increment_barcode is called twice in succession in
>cataloguing/additem.pl
>
>Test Plan:
>1) Enable autobarcode = incremental
>2) Catalog an item, not the barcode
>3) Apply this patch
>4) Catalog another item, the barcode should be the next in line
>   as previously. No change should be noted.
>---
> cataloguing/additem.pl |    5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index 36978bc..ea5563a 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -400,11 +400,6 @@ if ($op eq "additem") {
>         $record = _increment_barcode($record, $frameworkcode);
>     }
> 
>-
>-    if (C4::Context->preference('autoBarcode') eq 'incremental') {
>-        $record = _increment_barcode($record, $frameworkcode);
>-    }
>-
>     my $addedolditem = TransformMarcToKoha( $dbh, $record );
> 
>     # If we have to add or add & duplicate, we add the item
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 10305: 18281 | 20227 | 21370