Bugzilla – Attachment 20307 Details for
Bug 10718
items with no checkouts report does not work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10718 - select user branch as default
0002-Bug-10718-select-user-branch-as-default.patch (text/plain), 3.21 KB, created by
Fridolin Somers
on 2013-08-13 13:50:41 UTC
(
hide
)
Description:
Bug 10718 - select user branch as default
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2013-08-13 13:50:41 UTC
Size:
3.21 KB
patch
obsolete
>From 46283adcd951f07c713c4b421e66c726cbe83710 Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Tue, 13 Aug 2013 15:17:25 +0200 >Subject: [PATCH 2/5] Bug 10718 - select user branch as default > >In cgi-bin/koha/reports/catalogue_out.pl report, select in library filter the user logged-in. > >Test plan : >- Log into intranet with a normal user >- Got to "Items with no checkouts" reports >=> Your branch is selected >- Run report >=> You see "Filtered on : Branch = <your branch>" >- Come back to report >- Select "Any library" >- Run report >=> You do not see "Filtered on : Branch" >--- > .../prog/en/modules/reports/catalogue_out.tt | 24 +++++--------------- > reports/catalogue_out.pl | 2 +- > 2 files changed, 7 insertions(+), 19 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >index b098cc7..017c5da 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt >@@ -100,8 +100,12 @@ > <select name="Filter" id="branch"> > <option value="">Any library</option> > [% FOREACH branchloo IN branchloop %] >- <option value="[% branchloo.value %]">[% branchloo.branchname %]</option> >- [% END %] >+ [% IF ( branchloo.selected ) %] >+ <option value="[% branchloo.value %]" selected="selected">[% branchloo.branchname %]</option> >+ [% ELSE %] >+ <option value="[% branchloo.value %]">[% branchloo.branchname %]</option> >+ [% END %] >+ [% END %] > </select></li> > <li> > <label for="documenttype">Item type: </label><select name="Filter" id="documenttype"> >@@ -139,22 +143,6 @@ > </select></li> > </ol> > </fieldset> >-<!-- FIXME: Not implemented >- <fieldset class="rows"> >- <legend>Output</legend> >-<ol><li><label for="outputscreen">To screen into the browser: </label><input type="radio" checked="checked" name="output" id="outputscreen" value="screen" /> </li> >- <li><label for="outputfile">To a file: </label><input type="radio" name="output" value="file" id="outputfile" disabled="disabled" /> >- <label class="inline" for="basename">Named: </label><input type="text" name="basename" id="basename" value="Export" /> >- <label class="inline" for="MIME">Into an application </label> >- <select name="MIME" id="MIME"> >- [% FOREACH CGIextChoic IN CGIextChoice %] >- <option value="[% CGIextChoic.type %]">[% CGIextChoic.type %]</option> >- [% END %] >- </select> >- [% CGIsepChoice %] >- </li> >-</ol> >- </fieldset> --> > > <fieldset class="action"> > <input type="submit" value="Submit" /> >diff --git a/reports/catalogue_out.pl b/reports/catalogue_out.pl >index fb41c26..5811453 100755 >--- a/reports/catalogue_out.pl >+++ b/reports/catalogue_out.pl >@@ -72,7 +72,7 @@ foreach (sort {$itemtypes->{$a}->{description} cmp $itemtypes->{$b}->{descriptio > > $template->param( > itemtypeloop => \@itemtypeloop, >- branchloop => GetBranchesLoop($input->param("branch") || C4::Context->userenv->{branch}), >+ branchloop => GetBranchesLoop(), > ); > output_html_with_http_headers $input, $cookie, $template->output; > >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10718
:
20306
|
20307
|
20308
|
20309
|
20310
|
20570
|
20600
|
20886
|
20887