Bugzilla – Attachment 20329 Details for
Bug 9011
Add the ability to store the last patron to return an item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9011 - QA Followup
Bug-9011---QA-Followup.patch (text/plain), 4.50 KB, created by
Kyle M Hall (khall)
on 2013-08-14 13:47:38 UTC
(
hide
)
Description:
Bug 9011 - QA Followup
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-08-14 13:47:38 UTC
Size:
4.50 KB
patch
obsolete
>From 07fd44c274d451f7e1fbbfc1159ca8ae15d7ed34 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 14 Aug 2013 09:46:03 -0400 >Subject: [PATCH] Bug 9011 - QA Followup > >* Use template plugin to get syspref values >* Hide "last returned by" if AnonymousPatron is not set >--- > catalogue/moredetail.pl | 1 - > .../prog/en/modules/catalogue/moredetail.tt | 3 ++- > .../opac-tmpl/prog/en/modules/opac-privacy.tt | 2 +- > opac/opac-privacy.pl | 1 - > 4 files changed, 3 insertions(+), 4 deletions(-) > >diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl >index 730ab80..e092827 100755 >--- a/catalogue/moredetail.pl >+++ b/catalogue/moredetail.pl >@@ -212,7 +212,6 @@ $template->param( > z3950_search_params => C4::Search::z3950_search_args(GetBiblioData($biblionumber)), > subtitle => $subtitle, > hidepatronname => $hidepatronname, >- StoreLastBorrower => C4::Context->preference('StoreLastBorrower'), > ); > $template->param(ONLY_ONE => 1) if ( $itemnumber && $showncount != @items ); > $template->{'VARS'}->{'searchid'} = $query->param('searchid'); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index 77d05ab..b757b1f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -1,3 +1,4 @@ >+[% USE Koha %] > [% USE KohaBorrowers %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Catalog › Item details for [% title %] [% FOREACH subtitl IN subtitle %] [% subtitl.subfield %][% END %]</title> >@@ -213,7 +214,7 @@ > > <li><span class="label">Last seen:</span>[% IF ( ITEM_DAT.datelastseen ) %][% ITEM_DAT.datelastseen | $KohaDates %] [%END %] </li> > <li><span class="label">Last borrowed:</span>[% IF (ITEM_DAT.datelastborrowed ) %][% ITEM_DAT.datelastborrowed | $KohaDates %][% END %] </li> >- [% IF ( StoreLastBorrower && ITEM_DAT.last_returned_by ) %]<li><span class="label">Last returned by:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% ITEM_DAT.last_returned_by %]">[% KohaBorrowers.BorrowernumberToCardnumber( ITEM_DAT.last_returned_by ) %]</a> </li>[% END %] >+ [% IF ( ITEM_DAT.last_returned_by && Koha.Preference('StoreLastBorrower') && !Koha.Preference('AnonymousPatron') ) %]<li><span class="label">Last returned by:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% ITEM_DAT.last_returned_by %]">[% KohaBorrowers.BorrowernumberToCardnumber( ITEM_DAT.last_returned_by ) %]</a> </li>[% END %] > [% IF ( ITEM_DAT.card0 ) %]<li><span class="label">Last borrower:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% ITEM_DAT.borrower0 %]">[% ITEM_DAT.card0 %]</a> </li>[% END %] > [% IF ( ITEM_DAT.card1 ) %]<li><span class="label">Previous borrower:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% ITEM_DAT.borrower1 %]">[% ITEM_DAT.card1 %]</a> </li>[% END %] > [% IF ( ITEM_DAT.card2 ) %]<li><span class="label">Previous borrower:</span> <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% ITEM_DAT.borrower2 %]">[% ITEM_DAT.card2 %]</a> </li>[% END %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-privacy.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-privacy.tt >index 05d54ca..62f44ae 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-privacy.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-privacy.tt >@@ -62,7 +62,7 @@ > </form> > [% END %] > >- [% IF StoreLastBorrower %]<p>Please note, the last person to return an item is tracked for the management of items returned damaged.</p>[% END %] >+ [% IF Koha.Preference('StoreLastBorrower') %]<p>Please note, the last person to return an item is tracked for the management of items returned damaged.</p>[% END %] > </div> > </div> > </div> >diff --git a/opac/opac-privacy.pl b/opac/opac-privacy.pl >index 5905447..22fe694 100755 >--- a/opac/opac-privacy.pl >+++ b/opac/opac-privacy.pl >@@ -68,7 +68,6 @@ $template->param( 'Ask_data' => '1', > 'firstname' => $borr->{'firstname'}, > 'surname' => $borr->{'surname'}, > 'privacyview' => 1, >- 'StoreLastBorrower' => C4::Context->preference('StoreLastBorrower'), > ); > > output_html_with_http_headers $query, $cookie, $template->output; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9011
:
13258
|
15117
|
15200
|
16666
|
16763
|
16773
|
18676
|
20180
|
20181
|
20329
|
20342
|
20343
|
20344
|
22577
|
22578
|
22579
|
25866
|
25867
|
25868
|
25869
|
25870
|
25871
|
25872
|
25873
|
28923
|
28924
|
28925
|
29301
|
29745
|
29749
|
29750
|
29930
|
29931
|
30979
|
30993
|
30994
|
30995
|
30996
|
30997
|
30998
|
30999
|
32430
|
32431
|
32432
|
32433
|
32434
|
32435
|
32436
|
32437
|
32438
|
32439
|
32440
|
32441
|
32442
|
32443
|
32977
|
37113
|
37114
|
37115
|
37116
|
37117
|
38441
|
38442
|
38443
|
38444
|
38445
|
39812
|
39813
|
39814
|
39815
|
39816