Attachment 20373 Details for Bug 10736 – [SIGNED-OFF] Bug 10736: show duplicate invoice warning on second invoice

[patch] [SIGNED-OFF] Bug 10736: show duplicate invoice warning on second invoice

SIGNED-OFF-Bug-10736-show-duplicate-invoice-warnin.patch (text/plain), 1.34 KB, created by Nicole C. Engard on 2013-08-15 16:04:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2013-08-15 16:04:02 UTC

Size: 1.34 KB

patch

obsolete

>From 886d1d1c9af594f14dbe5d1c3efd7d945764d823 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Thu, 15 Aug 2013 11:28:30 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 10736: show duplicate invoice warning on second invoice
>
>If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2
>or more invoices with the same number. It should warn if you're trying to
>create a duplicate.
>
>To test:
>1) Turn on AcqWarnOnDuplicateInvoice.
>2) Try to create an invoice that duplicates an invoice number you are already
>   using exactly once.
>3) Note that you get a warning after applying this patch.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>all tests pass
>---
> acqui/parcels.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/acqui/parcels.pl b/acqui/parcels.pl
>index 37a0023..fbfa9fa 100755
>--- a/acqui/parcels.pl
>+++ b/acqui/parcels.pl
>@@ -112,7 +112,7 @@ if ( $op and $op eq 'new' ) {
>             supplierid    => $booksellerid,
>             invoicenumber => $invoicenumber,
>         );
>-        if ( $#invoices > 0 ) {
>+        if ( scalar @invoices > 0 ) {
>             $template->{'VARS'}->{'duplicate_invoices'} = \@invoices;
>             $template->{'VARS'}->{'invoicenumber'}      = $invoicenumber;
>             $template->{'VARS'}->{'shipmentdate'}       = $shipmentdate;
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 10736: 20372 | 20373 | 20391