Bugzilla – Attachment 20396 Details for
Bug 10664
Software error in overdue_notices.pl if there is no active currency
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10664 : Software error in overdue_notices.pl if there is no active currency
Bug-10664--Software-error-in-overduenoticespl-if-t.patch (text/plain), 1.68 KB, created by
Kyle M Hall (khall)
on 2013-08-16 11:23:17 UTC
(
hide
)
Description:
Bug 10664 : Software error in overdue_notices.pl if there is no active currency
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-08-16 11:23:17 UTC
Size:
1.68 KB
patch
obsolete
>From 4a3e2778233ab53184c4386b0eb161644b8bdf07 Mon Sep 17 00:00:00 2001 >From: Sophie Meynieux <sophie.meynieux@biblibre.com> >Date: Wed, 31 Jul 2013 08:04:25 +0200 >Subject: [PATCH] Bug 10664 : Software error in overdue_notices.pl if there is no active currency > >If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call > >With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated. > >Test plan : >- have at least one borrower with overdue that should trigger a notice >- verify that there is no active currency (Adminitration > Currency & Exchange rates) >- run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output) > >=> without the patch you get the software error >=> with the patch, notices are correctly generated > >If an active currency is defined, the script overdue_notices.pl runs the same with or without patch > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > misc/cronjobs/overdue_notices.pl | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 5f285c0..04ccf5a 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -688,7 +688,8 @@ sub parse_letter { > $tables{'branches'} = $p; > } > >- my $currency_format = GetCurrency()->{currency}; >+ my $currencies = GetCurrency(); >+ my $currency_format = $currencies->{currency} if defined($currencies); > > my @item_tables; > if ( my $i = $params->{'items'} ) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10664
:
19991
|
20032
| 20396 |
20397