Bugzilla – Attachment 20397 Details for
Bug 10664
Software error in overdue_notices.pl if there is no active currency
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10664 [QA Followup] - Software error in overdue_notices.pl if there is no active currency
Bug-10664-QA-Followup---Software-error-in-overduen.patch (text/plain), 1.09 KB, created by
Kyle M Hall (khall)
on 2013-08-16 11:23:29 UTC
(
hide
)
Description:
Bug 10664 [QA Followup] - Software error in overdue_notices.pl if there is no active currency
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-08-16 11:23:29 UTC
Size:
1.09 KB
patch
obsolete
>From 0f094521a97854373deb1b41516b01a18fb30692 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 16 Aug 2013 07:21:10 -0400 >Subject: [PATCH] Bug 10664 [QA Followup] - Software error in overdue_notices.pl if there is no active currency > >Fixes the following koha-qa.pl error: > FAIL misc/cronjobs/overdue_notices.pl > OK pod > OK forbidden patterns > OK valid > FAIL critic > # Variables::ProhibitConditionalDeclarations: >--- > misc/cronjobs/overdue_notices.pl | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 04ccf5a..0f263c4 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -689,7 +689,8 @@ sub parse_letter { > } > > my $currencies = GetCurrency(); >- my $currency_format = $currencies->{currency} if defined($currencies); >+ my $currency_format; >+ $currency_format = $currencies->{currency} if defined($currencies); > > my @item_tables; > if ( my $i = $params->{'items'} ) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10664
:
19991
|
20032
|
20396
| 20397