Attachment 20404 Details for Bug 10686 – Bug 10686: Remove fields from searches for highlighting

[patch] Bug 10686: Remove fields from searches for highlighting

Bug-10686-Remove-fields-from-searches-for-highligh.patch (text/plain), 2.75 KB, created by Kyle M Hall (khall) on 2013-08-16 12:39:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-08-16 12:39:57 UTC

Size: 2.75 KB

patch

obsolete

>From 5692412b1394289201277d3121bfe805b1517418 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Mon, 5 Aug 2013 20:56:48 -0400
>Subject: [PATCH] Bug 10686: Remove fields from searches for highlighting
>
>If you do a fielded search like au:smith, "Smith" will not get
>highlighted on the results page because the Javascript is looking for
>the exact string "au:smith."
>
>To test:
>1) Turn on OpacHighlightedWords.
>2) Do a simple keyword search.
>3) Confirm that the word is highlighted on the results and details page.
>4) Do a fielded search by entering au:smith (or whatever).
>5) Confirm that the word is highlighted on the results and details page.
>6) Sign off.
>
>Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Passes koha-qa.pl, works as advertised.
>---
> koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    1 +
> .../prog/en/modules/opac-results-grouped.tt        |    1 +
> .../opac-tmpl/prog/en/modules/opac-results.tt      |    1 +
> 3 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>index 9226dec..6f45872 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>@@ -58,6 +58,7 @@
>         function highlightOn() {
>             var x;
>             for (x in q_array) {
>+                q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1");
>                 $(".title").highlight(q_array[x]);
>                 $(".author").highlight(q_array[x]);
>                 $(".results_summary").highlight(q_array[x]);
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt
>index d6b4c11..141a733 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt
>@@ -83,6 +83,7 @@ function highlightOff() {
> function highlightOn() {
>     var x;
>     for (x in q_array) {
>+        q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1");
>         $("td").highlight(q_array[x]);
>     }
>     $(".highlight_toggle").toggle();
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>index 0df0322..e1ef451 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
>@@ -98,6 +98,7 @@ function highlightOff() {
> function highlightOn() {
>     var x;
>     for (x in q_array) {
>+        q_array[x] = q_array[x].replace(/\w*:([\w])/, "$1");
>         if ( q_array[x].length > 0 ) {
>             $(".title").highlight(q_array[x]);
>             $(".author").highlight(q_array[x]);
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 10686: 20119 | 20192 | 20404