Bugzilla – Attachment 20405 Details for
Bug 10028
ModReceiveOrder works unexpectedly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10028: ModReceiveOrder unexpectedly works.
Bug-10028-ModReceiveOrder-unexpectedly-works.patch (text/plain), 1.32 KB, created by
Kyle M Hall (khall)
on 2013-08-16 12:56:01 UTC
(
hide
)
Description:
Bug 10028: ModReceiveOrder unexpectedly works.
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-08-16 12:56:01 UTC
Size:
1.32 KB
patch
obsolete
>From c45715876fc81646fefdfdb8ab1e1472bff661e5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 11 Apr 2013 12:00:45 +0200 >Subject: [PATCH] Bug 10028: ModReceiveOrder unexpectedly works. > >In C4::Acquisition::ModReceiveOrder, a call to NewOrder is badly used. > >NewOrder returns ($basketno, $ordernumber) but in ModReceiveOrder the >ordernumber is got with > my $ordernumber = NewOrder( $args ); > >It works because: >sub t{ > return ("a", "b"); >} >my $a = t(); >say $a; > >Will display 'b'. > >But it is not really clear. > >Test plan: >Check that there is no regression for partial receives. > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Acquisition.pm | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 1a210b5..74aae85 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1355,7 +1355,8 @@ sub ModReceiveOrder { > $order->{'rrp'} = $rrp; > $order->{ecost} = $ecost; > $order->{'orderstatus'} = 3; # totally received >- $new_ordernumber = NewOrder($order); >+ my $basketno; >+ ( $basketno, $new_ordernumber ) = NewOrder($order); > > if ($received_items) { > foreach my $itemnumber (@$received_items) { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10028
:
17370
|
20211
| 20405