Attachment 20572 Details for Bug 10741 – Bug 10741 - Can not place a hold on an item in transit and for loan

[patch] Bug 10741 - Can not place a hold on an item in transit and for loan

Bug-10741---Can-not-place-a-hold-on-an-item-in-tra.patch (text/plain), 1.78 KB, created by Chris Cormack on 2013-08-23 03:17:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2013-08-23 03:17:38 UTC

Size: 1.78 KB

patch

obsolete

>From 62b6990d3d69c5ba12213ecdbe38f34a18cce806 Mon Sep 17 00:00:00 2001
>From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
>Date: Fri, 16 Aug 2013 13:36:10 +0200
>Subject: [PATCH] Bug 10741 - Can not place a hold on an item in transit and
> for loan
>
>In search results, one can not place a hold on an item in transit and for loan (items.notforloan=0).
>This appears when AllowOnShelfHolds is allowed.
>
>Depends on Bug 8975 code : a simple if condition is missing when not damaged.
>
>Test plan :
>- Set AllowOnShelfHolds to on
>- Create a record with a normal item : not lost, not withdrawn, not damaged, notforloan=0
>- Index this record
>- Perform a search on OPAC that returns this record (and others)
>=> You see in actions "Place hold"
>- Add this item in transit : /cgi-bin/koha/circ/branchtransfers.pl
>- Re-perform the search on OPAC
>=> You see in actions "Place hold" and item "in transit"
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> C4/Search.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Search.pm b/C4/Search.pm
>index aec024b..4e4edb0 100644
>--- a/C4/Search.pm
>+++ b/C4/Search.pm
>@@ -1950,8 +1950,8 @@ sub searchResults {
>                                         $can_place_holds = 1;
>                                     }
>                                 }
>-                            } elsif ( $item->{notforloan} < 0 ) {
>-                                # item is not damaged and notforloan is < 0
>+                            } elsif ( !$item->{notforloan} || $item->{notforloan} < 0 ) {
>+                                # item is not damaged and item is either for loan or has notforloan < 0
>                                 $can_place_holds = 1;
>                             }
>                         }
>-- 
>1.8.1.2

Actions: View | Diff | Splinter Review

Attachments on bug 10741: 20401 | 20402 | 20549 | 20550 | 20571 | 20572 | 20573