Attachment 20599 Details for Bug 10710 – [PASSED QA] Bug 10710: (follow-up) perltidy new code

[patch] [PASSED QA] Bug 10710: (follow-up) perltidy new code

PASSED-QA-Bug-10710-follow-up-perltidy-new-code.patch (text/plain), 2.31 KB, created by Katrin Fischer on 2013-08-25 18:02:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-08-25 18:02:44 UTC

Size: 2.31 KB

patch

obsolete

>From f0a4fafccecb5d535caafdcc8417c606db895dd2 Mon Sep 17 00:00:00 2001
>From: Galen Charlton <gmc@esilibrary.com>
>Date: Wed, 14 Aug 2013 16:37:49 +0000
>Subject: [PATCH] [PASSED QA] Bug 10710: (follow-up) perltidy new code
>
>Also, I prefer the use of parentheses for function
>calls, even when no arguments are being passed.
>One missed comma turns
>
>is(GetOfflineOperation, ...)
>
>into
>
>is(GetOfflineOperation ...)
>
>Signed-off-by: Galen Charlton <gmc@esilibrary.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>---
> t/db_dependent/Circulation_OfflineOperation.t |   14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
>diff --git a/t/db_dependent/Circulation_OfflineOperation.t b/t/db_dependent/Circulation_OfflineOperation.t
>index 46ecb3b..2f5edf8 100644
>--- a/t/db_dependent/Circulation_OfflineOperation.t
>+++ b/t/db_dependent/Circulation_OfflineOperation.t
>@@ -71,7 +71,7 @@ is_deeply(
>     {
>         operationid => $offline_id,
>         userid      => 'User1',
>-        branchcode  =>  $samplebranch1->{branchcode},
>+        branchcode  => $samplebranch1->{branchcode},
>         timestamp   => "0000-00-00 00:00:00",
>         action      => 'Action1',
>         barcode     => 'CODE',
>@@ -80,16 +80,20 @@ is_deeply(
>     },
>     "GetOffline returns offlineoperation's informations"
> );
>-is(GetOfflineOperation,undef,'GetOfflineOperation without parameters returns undef');
>-is(GetOfflineOperation(-1),undef,'GetOfflineOperation with wrong parameters returns undef');
>+is( GetOfflineOperation(), undef,
>+    'GetOfflineOperation without parameters returns undef' );
>+is( GetOfflineOperation(-1), undef,
>+    'GetOfflineOperation with wrong parameters returns undef' );
> 
> #Test GetOfflineOperations
> #TODO later: test GetOfflineOperations
> # Actually we cannot mock C4::Context->userenv in unit tests
> 
> #Test DeleteOfflineOperation
>-is (DeleteOfflineOperation($offline_id),'Deleted.','Offlineoperation has been deleted');
>-#is (DeleteOfflineOperation, undef, 'DeleteOfflineOperation without id returns undef');
>+is( DeleteOfflineOperation($offline_id),
>+    'Deleted.', 'Offlineoperation has been deleted' );
>+
>+#is (DeleteOfflineOperation(), undef, 'DeleteOfflineOperation without id returns undef');
> #is (DeleteOfflineOperation(-1),undef, 'DeleteOfflineOperation with a wrong id returns undef');#FIXME
> 
> #End transaction
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 10710: 20267 | 20349 | 20350 | 20598 | 20599