Bugzilla – Attachment 20604 Details for
Bug 10349
Don't show empty Descriptions/Title notes tabs in OPAC and staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff
PASSED-QA-Bug-10349---Dont-show-empty-Descriptions.patch (text/plain), 3.81 KB, created by
Katrin Fischer
on 2013-08-25 19:35:24 UTC
(
hide
)
Description:
[PASSED QA] Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-08-25 19:35:24 UTC
Size:
3.81 KB
patch
obsolete
>From 0e2e8d66b381bd80f3050b7eb489c825a2bab59a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 31 May 2013 12:05:49 -0400 >Subject: [PATCH] [PASSED QA] Bug 10349 - Don't show empty Descriptions/Title > notes tabs in OPAC and staff > >The descriptions/title notes tab appears on the detail page in both >staff client and OPAC even if there are no notes. This is probably a >relic of the pre-T:T days when it wasn't possible to use || in an IF. >This patch adds a check for the various variables which might trigger >the display of the tab. > >To test, apply the patch and view records in the OPAC and staff client >which do and do not have title notes attached (whether that be in the >MARC reocrd or in the biblio.notes column). In the OPAC Syndetics >content should also be tested if possible. The descriptions/title notes >tab should only appear if there is content. > >Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >That's better - thx Owen! >Works nicely and passes all tests. >Tested in staff and OPAC, also in combination with NotesBlacklist >hiding all notes. >--- > .../prog/en/modules/catalogue/detail.tt | 8 ++++++-- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 8 +++++++- > 2 files changed, 13 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 1011224..75c9870 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -368,7 +368,7 @@ function verify_images() { > [% ELSE %] > <li><a href="#holdings">Holdings</a></li> > [% END %] >-<li><a href="#description">Descriptions</a></li> >+[% IF ( MARCNOTES || notes ) %]<li><a href="#description">Descriptions</a></li>[% END %] > [% IF ( subscriptionsnumber ) %]<li><a href="#subscriptions">Subscriptions</a></li>[% END %] > [% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %]<li><a href="#editions">Editions</a></li>[% END %][% END %] > [% IF ( LocalCoverImages ) %][% IF ( localimages || CAN_user_tools_upload_local_cover_images ) %]<li><a href="#images">Images</a></li>[% END %][% END %] >@@ -606,7 +606,9 @@ function verify_images() { > [% END %] > </div> > [% END %] >- >+ >+[% IF ( MARCNOTES || notes ) %] >+ > <div id="description"> > <div class="content_set"> > >@@ -622,6 +624,8 @@ function verify_images() { > </div> > </div> > >+[% END %] >+ > [% IF ( subscriptionsnumber ) %] > <div id="subscriptions"> > <div class="yui-g"> >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index 77a62f0..c3d59d4 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -943,7 +943,9 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > [% IF (SeparateHoldings) %] > <li><a href="#otherholdings">Other holdings ( [% otheritemloop.size || 0 %] )</a></li> > [% END %] >-<li id="tab_descriptions"> <a href="#descriptions">Title notes</a></li> >+[% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] >+ <li id="tab_descriptions"> <a href="#descriptions">Title notes</a></li> >+[% END %] > [% IF ( SYNDETICS_TOC ) %] > <li id="tab_toc"> <a href="#toc">TOC</a></li> > [% END %] >@@ -1081,6 +1083,8 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > </div> > [% END %] > >+[% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %] >+ > <div id="descriptions"> > <div class="content_set"> > >@@ -1108,6 +1112,8 @@ YAHOO.util.Event.onContentReady("furtherm", function () { > </div> > </div> > >+[% END %] >+ > [% IF ( SyndeticsEnabled ) %] > > [% IF ( SyndeticsTOC ) %][% IF ( SYNDETICS_TOC ) %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10349
:
18553
|
19967
| 20604