Bugzilla – Attachment 20649 Details for
Bug 10711
GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result
Bug-10711-GetOfflineOperation-in-C4Circulationpm-s.patch (text/plain), 1.47 KB, created by
Chris Cormack
on 2013-08-27 09:55:38 UTC
(
hide
)
Description:
Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-08-27 09:55:38 UTC
Size:
1.47 KB
patch
obsolete
>From c8f144deec3d7fcb8d299ab14ce2e83ad4779c85 Mon Sep 17 00:00:00 2001 >From: Kenza Zaki <kenza.zaki@biblibre.com> >Date: Mon, 12 Aug 2013 14:40:50 +0200 >Subject: [PATCH] Bug 10711: GetOfflineOperation in C4/Circulation.pm should > returns $sth->fetchrow_hashref instead of $result > >To test : >prove t/db_dependent/Circulation_OfflineOperation.t >t/db_dependent/Circulation_OfflineOperation.t .. ok >All tests successful. >Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) >Result: PASS > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Comment: applied 10681 and 10710 before 10711 >prove t/db_dependent/Circulation_OfflineOperation.t run without errors >koha-qa reports only 2 tabulations, fixed in a follow-up > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > C4/Circulation.pm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 02fe6b0..35a90c7 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -3306,11 +3306,12 @@ sub GetOfflineOperations { > } > > sub GetOfflineOperation { >+ my $operationid = shift; >+ return unless $operationid; > my $dbh = C4::Context->dbh; > my $sth = $dbh->prepare("SELECT * FROM pending_offline_operations WHERE operationid=?"); >- $sth->execute( shift ); >- my $result = $sth->fetchrow_hashref; >- return $result; >+ $sth->execute( $operationid ); >+ return $sth->fetchrow_hashref; > } > > sub AddOfflineOperation { >-- >1.8.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10711
:
20269
|
20617
|
20618
| 20649 |
20650