Bugzilla – Attachment 20748 Details for
Bug 10795
Improvements for GetOpenIssue in C4::Circulation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation
SIGNED-OFF-Bug-10795---Improvements-for-GetOpenIss.patch (text/plain), 1.53 KB, created by
Bernardo Gonzalez Kriegel
on 2013-08-31 02:21:43 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2013-08-31 02:21:43 UTC
Size:
1.53 KB
patch
obsolete
>From 268d7b44b23a17456a9ceea5fadcc143ab197598 Mon Sep 17 00:00:00 2001 >From: Kenza Zaki <kenza.zaki@biblibre.com> >Date: Wed, 28 Aug 2013 10:46:07 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 10795 - Improvements for GetOpenIssue in > C4::Circulation > >This patch adds some improvements for the routine GetOpenIssue. >Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. > >To test: >prove t/db_dependent/Circulation_issue.t >t/db_dependent/Circulation_issue.t .. ok >All tests successful. >Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) >Result: PASS > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Comment: Same situation as the one noted in comment of >Bug 10683, test fails unless there is an issuingrule >All, All with 1 as renewals allowed. > >With that condition, it succeeds > >No koha-qa errors >--- > C4/Circulation.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 91a3eff..dadb20b 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2309,12 +2309,12 @@ Returns a hashref > > sub GetOpenIssue { > my ( $itemnumber ) = @_; >- >+ return unless $itemnumber; > my $dbh = C4::Context->dbh; > my $sth = $dbh->prepare( "SELECT * FROM issues WHERE itemnumber = ? AND returndate IS NULL" ); > $sth->execute( $itemnumber ); >- my $issue = $sth->fetchrow_hashref(); >- return $issue; >+ return $sth->fetchrow_hashref(); >+ > } > > =head2 GetItemIssues >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10795
:
20690
|
20748
|
20828