Attachment 20756 Details for Bug 10720 – Bug 10720 : substitution term in overdue notices shouldn't be removed if they don't match. It prevents use of html in notices to use with css

[patch] Bug 10720 : substitution term in overdue notices shouldn't be removed if they don't match. It prevents use of html in notices to use with css

Bug-10720--substitution-term-in-overdue-notices-sh.patch (text/plain), 1.76 KB, created by Srdjan Jankovic on 2013-09-02 06:02:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2013-09-02 06:02:49 UTC

Size: 1.76 KB

patch

obsolete

>From 7f1e254d42fd1ab97f89c7eb6b5e8398875b886d Mon Sep 17 00:00:00 2001
>From: Sophie Meynieux <sophie.meynieux@biblibre.com>
>Date: Tue, 13 Aug 2013 18:14:21 +0200
>Subject: [PATCH] Bug 10720 : substitution term in overdue notices shouldn't be
> removed if they don't match. It prevents use of html in notices to use with
> css
>
>        Test plan :
>        - define an overdue notice containing some valid substitution terms + some valid html tags (<strong> or <div class="my class" to use with a css
>        - find a borrower with overdues that trigger this notice
>        - run overdue_notices.pl -html <directory>
>
>        Without patch, your html tags are missing in your html file
>        With the patch, they are present and can be used with a css to generate a formatted pdf file.
>
>        If you add some invalid substitution term, with the patch, they are still in the final letter, but the warn in the log helps you to correct your notice template.
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> misc/cronjobs/overdue_notices.pl | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index 0f263c4..00e2e5b 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -568,8 +568,6 @@ END_SQL
>                 if (@misses) {
>                     $verbose and warn "The following terms were not matched and replaced: \n\t" . join "\n\t", @misses;
>                 }
>-                $letter->{'content'} =~ s/\<[^<>]*?\>//g;    # Now that we've warned about them, remove them.
>-                $letter->{'content'} =~ s/\<[^<>]*?\>//g;    # 2nd pass for the double nesting.
> 
>                 if ( !$nomail && scalar @emails_to_use ) {
>                     C4::Letters::EnqueueLetter(
>-- 
>1.8.1.2

Actions: View | Diff | Splinter Review

Attachments on bug 10720: 20320 | 20756 | 20829