Bugzilla – Attachment 20822 Details for
Bug 10652
Ajaxfileupload.js failing in IE9 for local image upload
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10652 - Ajaxfileupload.js failing in IE9 for local image upload
Bug-10652---Ajaxfileuploadjs-failing-in-IE9-for-lo.patch (text/plain), 2.15 KB, created by
Kyle M Hall (khall)
on 2013-09-06 11:33:59 UTC
(
hide
)
Description:
Bug 10652 - Ajaxfileupload.js failing in IE9 for local image upload
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-09-06 11:33:59 UTC
Size:
2.15 KB
patch
obsolete
>From 87ec902a9a30b1c2220edacbb3392907380b9d87 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 29 Jul 2013 13:02:26 +1000 >Subject: [PATCH] Bug 10652 - Ajaxfileupload.js failing in IE9 for local image upload > >This patch adds a try/catch to the Javascript for adding the iframe >element. The try will work for IE8 and older versions, while newer >versions and other browsers will be covered by the check. > >Test Plan: > >1) Try uploading a local cover image in IE9 >2) Notice that your page is reloaded with no result (except the >pop-up of a Javascript error, if you have error reporting on in >your browser). > >3) Apply the patch > >4) Trying uploading a local cover image again >5) Notice that it uploads correctly > >6) Repeat steps 4 and 5 for IE8, IE7, and/or other modern browsers. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Tested in IE10 in IE10 "browser mode" and IE9 mode as well as in >Firefox. Uploads work correctly with book cover images and in MARC >uploads. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Also verified as working in Chrome. >--- > .../prog/en/lib/jquery/plugins/ajaxfileupload.js | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/ajaxfileupload.js b/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/ajaxfileupload.js >index 8bb2c17..0e1d75b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/ajaxfileupload.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/ajaxfileupload.js >@@ -6,7 +6,7 @@ jQuery.extend({ > //create frame > var frameId = 'jUploadFrame' + id; > >- if(window.ActiveXObject) { >+ try { > var io = document.createElement('<iframe id="' + frameId + '" name="' + frameId + '" />'); > if(typeof uri== 'boolean'){ > io.src = 'javascript:false'; >@@ -15,7 +15,7 @@ jQuery.extend({ > io.src = uri; > } > } >- else { >+ catch(e) { > var io = document.createElement('iframe'); > io.id = frameId; > io.name = frameId; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10652
:
19971
|
20111
| 20822