Bugzilla – Attachment 20826 Details for
Bug 10656
shelving locations not alpha on search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10656: improve sorting of shelving location and collections on OPAC advanced search form
Bug-10656-improve-sorting-of-shelving-location-and.patch (text/plain), 1.89 KB, created by
Kyle M Hall (khall)
on 2013-09-06 15:24:16 UTC
(
hide
)
Description:
Bug 10656: improve sorting of shelving location and collections on OPAC advanced search form
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-09-06 15:24:16 UTC
Size:
1.89 KB
patch
obsolete
>From cc1773983c0d84f854aff9e877a466c34b0ca5f1 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 1 Aug 2013 09:14:08 -0400 >Subject: [PATCH] Bug 10656: improve sorting of shelving location and collections on OPAC advanced search form > >Collection codes and shelving locations are displayed in the OPAC and >staff client via GetAuthorisedValues which currently sorts results by >"lib, lib_opac." Consequently if lib (the description for the staff >client) doesn't match lib_opac (the description for the OPAC) sorting >will appear to be nonsensical in the OPAC. GetAuthorisedValues can be >passed an $opac parameter, so this should be used to switch how reuslts >are sorted. This patch implements such a switch. > >To test, modify your collection code or shelving location authorized >values so that lib and lib_opac do not match. Set your >AdvancedSearchTypes system preference to display the modified authorized >values and view the advanced search page in the OPAC and staff client. >Sorting should be correct in each case according to the correct value >(lib in the staff client, lib_opac in the OPAC). > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >Tested in staff and opac and it works perfectly! > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Koha.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 6f91b8b..5deb61b 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -1076,7 +1076,7 @@ sub GetAuthorisedValues { > if(@where_strings > 0) { > $query .= " WHERE " . join(" AND ", @where_strings); > } >- $query .= " GROUP BY lib ORDER BY category, lib, lib_opac"; >+ $query .= " GROUP BY lib ORDER BY category, " . ($opac ? "lib_opac, lib" : "lib, lib_opac"); > > my $sth = $dbh->prepare($query); > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10656
:
19978
|
19979
|
20039
|
20040
|
20502
|
20507
|
20508
|
20509
|
20512
|
20513
|
20514
|
20825
| 20826 |
20827