Bugzilla – Attachment 20844 Details for
Bug 10820
Lost items on search results don't jive with record details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10820 - Lost items on search results don't jive with record details
Bug-10820---Lost-items-on-search-results-dont-jive.patch (text/plain), 2.76 KB, created by
Chris Cormack
on 2013-09-07 07:14:35 UTC
(
hide
)
Description:
Bug 10820 - Lost items on search results don't jive with record details
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-09-07 07:14:35 UTC
Size:
2.76 KB
patch
obsolete
>From f9b412cdd1812337faa45461198c40217145cdb9 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 4 Sep 2013 12:14:07 -0400 >Subject: [PATCH] Bug 10820 - Lost items on search results don't jive with > record details > >In the OPAC, if an items is both lost and checked out, it will show as >lost on the search results, and checkout out in the record details. The >lost status should take precedence over the checked out status, as the >checked out status may lead a patron to believe the book may return >soon. > >Test Plan: >1) Check an item out to a patron >2) Set it to lost ( requires itemlost to be revealed in the framework > for the items editor ). >3) Rebuild your zebra indexes >4) Run a search where that item is in the results list >5) Note the item is marked as lost >6) View the record details >7) Note the item is listed as "checked out" >8) Apply this patch >9) Repeat steps 4-6, note the item is now listed as lost > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > .../opac-tmpl/prog/en/includes/item-status.inc | 24 +++++++++++----------- > 1 file changed, 12 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc b/koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc >index 98fdb38..c0aa10c 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc >@@ -1,6 +1,17 @@ > [% USE KohaAuthorisedValues %] > >-[% IF ( item.datedue ) %] >+[% IF ( item.itemlost ) %] >+ [% av_lib_include = KohaAuthorisedValues.GetByCode( 'LOST', item.itemlost, 1 ) %] >+ [% IF ( av_lib_include ) %] >+ [% av_lib_include %] >+ [% ELSE %] >+ [% IF ( item.lostimageurl ) %] >+ <img src="[% item.lostimageurl %]" alt="[% item.lostimagelabel %]" title="[% item.lostimagelabel %]"> >+ [% ELSE %] >+ Item lost >+ [% END %] >+ [% END %] >+[% ELSIF ( item.datedue ) %] > [% IF ( OPACShowCheckoutName ) %] > Checked out to [% item.cardnumber %] [% item.firstname %] [% item.surname %] > [% ELSE %] >@@ -13,17 +24,6 @@ > On hold > [% ELSIF ( item.wthdrawn ) %] > Item withdrawn >-[% ELSIF ( item.itemlost ) %] >- [% av_lib_include = KohaAuthorisedValues.GetByCode( 'LOST', item.itemlost, 1 ) %] >- [% IF ( av_lib_include ) %] >- [% av_lib_include %] >- [% ELSE %] >- [% IF ( item.lostimageurl ) %] >- <img src="[% item.lostimageurl %]" alt="[% item.lostimagelabel %]" title="[% item.lostimagelabel %]"> >- [% ELSE %] >- Item lost >- [% END %] >- [% END %] > [% ELSIF ( item.itemnotforloan ) %] > [% IF ( item.notforloanvalueopac ) %] > [% item.notforloanvalueopac %] [% IF ( item.restrictedopac ) %]<span class="restricted">([% item.restrictedopac %])</span>[% END %] >-- >1.8.4.rc2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10820
:
20780
|
20844
|
21355