Attachment 20870 Details for Bug 10810 – [SIGNED-OFF] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl

[patch] [SIGNED-OFF] Bug 10810 - Fix synopsis for -html option to overdue_notices.pl

SIGNED-OFF-Bug-10810---Fix-synopsis-for--html-opti.patch (text/plain), 2.42 KB, created by Bernardo Gonzalez Kriegel on 2013-09-08 01:28:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bernardo Gonzalez Kriegel

Created: 2013-09-08 01:28:19 UTC

Size: 2.42 KB

patch

obsolete

>From 4051f48a8ab871707d2be5c288219382a32e97df Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@enger.priv.no>
>Date: Sat, 31 Aug 2013 15:33:24 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 10810 - Fix synopsis for -html option to
> overdue_notices.pl
>
>The synopsis for the -html option used to be:
>  -html <filename> Output html to file
>but the argument to this option should actually be a directory,
>not a filename. This patch fixes the synopsis.
>
>To test:
>- Run perldoc misc/cronjobs/overdue_notices.pl
>- Check that the synopsis is as shown above
>- Apply this patch
>- Run perldoc misc/cronjobs/overdue_notices.pl
>- Check that
>  - the synopsis asks for a directory, not a filename
>  - that the description of the -html option further down in the
>    perldoc now mentions the filename that the HTML file will be
>    created with.
>
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
>Works as described. No koha-qa errors.
>
>If feeded with a filename -html option fails with many messages like
>print() on closed filehandle $html_fh at misc/cronjobs/overdue_notices.pl line 384.
>Perhaps it could be improved, but that was the old behavior.
>---
> misc/cronjobs/overdue_notices.pl |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
>index 0f263c4..598f922 100755
>--- a/misc/cronjobs/overdue_notices.pl
>+++ b/misc/cronjobs/overdue_notices.pl
>@@ -60,7 +60,7 @@ overdue_notices.pl
>    -max          <days>           maximum days overdue to deal with
>    -library      <branchname>     only deal with overdues from this library (repeatable : several libraries can be given)
>    -csv          <filename>       populate CSV file
>-   -html         <filename>       Output html to file
>+   -html         <directory>      Output html to a file in the given directory
>    -itemscontent <list of fields> item information in templates
>    -borcat       <categorycode>   category code that must be included
>    -borcatout    <categorycode>   category code that must be excluded
>@@ -113,6 +113,8 @@ overdues that could not be emailed are sent in CSV format to the admin.
> Produces html data. if patron does not have a mail address or
> -n (no mail) flag is set, an html file is generated in the specified
> directory. This can be downloaded or futher processed by library staff.
>+The file will be called notices-YYYY-MM-DD.html and placed in the directory
>+specified.
> 
> =item B<-itemscontent>
> 
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 10810: 20749 | 20870 | 20976