Bugzilla – Attachment 20911 Details for
Bug 10841
Edit/Delete item context links in items table are not translatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10841: Make edit/delete item context links in cataloguing translatable
SIGNED-OFF-Bug-10841-Make-editdelete-item-context-.patch (text/plain), 4.29 KB, created by
Owen Leonard
on 2013-09-09 13:14:50 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10841: Make edit/delete item context links in cataloguing translatable
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-09-09 13:14:50 UTC
Size:
4.29 KB
patch
obsolete
>From 85f34c47deb2820c6084cd9164779ccadedd2716 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 8 Sep 2013 01:03:35 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 10841: Make edit/delete item context links > in cataloguing translatable >Content-Type: text/plain; charset="utf-8" > >HTML created with Javascript is not translatable the way HTML is >normally translated. _() syntax has to be used to have strings >translatable. > >To test: >- Edit items for a record with multiple items >- Click somewhere in the items table >- Verify the links for editing and deleting items show up and work correctly >- Apply patch >- Verify the links still show the same behaviour > >Bonus: >- Run 'perl translate update <languagecode>' in misc/translator >- Verify that Edit item and Delete item show up in the po file, translate them >- Install updated po files running 'perl translate install <languagecode>' >- Verify links show up translated and work correctly > >Patch also fixes capitalization for a couple of error messages - only change >there is: Deleted > deleted. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/cataloguing/additem.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >index 8cc064b..f5fecef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt >@@ -27,7 +27,7 @@ $(document).ready(function(){ > var rowid = $(this).parent().attr("id"); > num_rowid = rowid.replace("row",""); > $(".linktools").remove(); >- $(this).append("<span class=\"linktools\"><a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&frameworkcode=[% frameworkcode %]&biblionumber=[% biblionumber %]&itemnumber="+num_rowid+"#edititem\">Edit Item</a> <a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=delitem&frameworkcode=[% frameworkcode %]&biblionumber=[% biblionumber %]&itemnumber="+num_rowid+"\" onclick=\"confirm_deletion([% biblionumber %],"+num_rowid+"); return false;\">Delete Item</a></span>"); >+ $(this).append("<span class=\"linktools\"><a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&frameworkcode=[% frameworkcode %]&biblionumber=[% biblionumber %]&itemnumber="+num_rowid+"#edititem\">" + _("Edit item") + "</a> <a href=\"/cgi-bin/koha/cataloguing/additem.pl?op=delitem&frameworkcode=[% frameworkcode %]&biblionumber=[% biblionumber %]&itemnumber="+num_rowid+"\" onclick=\"confirm_deletion([% biblionumber %],"+num_rowid+"); return false;\">" + _("Delete item") + "</a></span>"); > } > }); > }); >@@ -114,10 +114,10 @@ $(document).ready(function() { > > [% IF ( barcode_not_unique ) %]<div class="dialog alert"><strong>Error saving item</strong>: Barcode must be unique.</div>[% END %] > [% IF ( no_next_barcode ) %]<div class="dialog alert"><strong>Error saving items</strong>: Unable to automatically determine values for barcodes. No item has been inserted.</div>[% END %] >-[% IF ( book_on_loan ) %]<div class="dialog alert"><strong>Cannot Delete</strong>: item is checked out.</div>[% END %] >-[% IF ( book_reserved ) %]<div class="dialogalert"><strong>Cannot Delete</strong>: item has a waiting hold.</div>[% END %] >-[% IF ( not_same_branch ) %]<div class="dialog alert"><strong>Cannot Delete</strong>: The items do not belong to your library.</div>[% END %] >-[% IF ( linked_analytics ) %]<div class="dialog alert"><strong>Cannot Delete</strong>: item has linked <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]&analyze=1">analytics.</a>.</div>[% END %] >+[% IF ( book_on_loan ) %]<div class="dialog alert"><strong>Cannot delete</strong>: item is checked out.</div>[% END %] >+[% IF ( book_reserved ) %]<div class="dialogalert"><strong>Cannot delete</strong>: item has a waiting hold.</div>[% END %] >+[% IF ( not_same_branch ) %]<div class="dialog alert"><strong>Cannot delete</strong>: The items do not belong to your library.</div>[% END %] >+[% IF ( linked_analytics ) %]<div class="dialog alert"><strong>Cannot delete</strong>: item has linked <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber %]&analyze=1">analytics.</a>.</div>[% END %] > > <div id="cataloguing_additem_itemlist"> > [% IF ( item_loop ) %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10841
:
20868
|
20911
|
20919