Attachment 21041 Details for Bug 7933 – Bug 7933: QA Followup - Remove unnecessary object creation

[patch] Bug 7933: QA Followup - Remove unnecessary object creation

Bug-7933-QA-Followup---Remove-unnecessary-object-c.patch (text/plain), 1013 bytes, created by Kyle M Hall (khall) on 2013-09-12 13:54:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2013-09-12 13:54:55 UTC

Size: 1013 bytes

patch

obsolete

>From 6c98feae578295697083fcfdf6899adf8d910e07 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 12 Sep 2013 09:27:50 -0400
>Subject: [PATCH] Bug 7933: QA Followup - Remove unnecessary object creation
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Biblio.pm |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Biblio.pm b/C4/Biblio.pm
>index 16c6e94..9211001 100644
>--- a/C4/Biblio.pm
>+++ b/C4/Biblio.pm
>@@ -1274,8 +1274,7 @@ sub GetMarcBiblio {
>     return unless $marcxml;
> 
>     MARC::File::XML->default_record_format( C4::Context->preference('marcflavour') );
>-    my $record = MARC::Record->new();
>-    $record = eval { MARC::Record::new_from_xml( $marcxml, "utf8", C4::Context->preference('marcflavour') ) };
>+    my $record = eval { MARC::Record::new_from_xml( $marcxml, "utf8", C4::Context->preference('marcflavour') ) };
>     if ($@) { warn " problem with :$biblionumber : $@ \n$marcxml"; }
>     return unless $record;
> 
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 7933: 9045 | 9046 | 9308 | 13707 | 16231 | 18913 | 18914 | 20880 | 20881 | 21018 | 21039 | 21040 | 21041