Bugzilla – Attachment 21056 Details for
Bug 10402
Add multiple contacts for vendors
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10402 follow-up: fix perlcritic exception
Bug-10402-follow-up-fix-perlcritic-exception.patch (text/plain), 945 bytes, created by
Jared Camins-Esakov
on 2013-09-12 18:41:21 UTC
(
hide
)
Description:
Bug 10402 follow-up: fix perlcritic exception
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2013-09-12 18:41:21 UTC
Size:
945 bytes
patch
obsolete
>From 0c76039579cffeaa246c083b397870ba8ea325a5 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Thu, 12 Sep 2013 14:39:29 -0400 >Subject: [PATCH] Bug 10402 follow-up: fix perlcritic exception > >Perlcritic doesn't like the syntax keys $variable, and requires that >you explicitly dereference a hashref to a hash before using keys. >--- > acqui/supplier.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/supplier.pl b/acqui/supplier.pl >index c480c2a..8161300 100755 >--- a/acqui/supplier.pl >+++ b/acqui/supplier.pl >@@ -67,7 +67,7 @@ my $booksellerid = $query->param('booksellerid'); > my $supplier = {}; > if ($booksellerid) { > $supplier = GetBookSellerFromId($booksellerid); >- foreach ( keys $supplier ) { >+ foreach ( keys %{$supplier} ) { > $template->{'VARS'}->{$_} = $supplier->{$_}; > } > $template->{'VARS'}->{'booksellerid'} = $booksellerid; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10402
:
18973
|
18974
|
18975
|
19233
|
19234
|
19235
|
19603
|
19604
|
19808
|
19809
|
19810
|
20019
|
20020
|
20021
|
20045
|
20046
|
20047
|
20048
|
20559
|
20560
|
20561
|
20562
|
21019
|
21020
|
21021
|
21022
|
21023
|
21056
|
21547
|
21549
|
21804
|
23370
|
23371
|
23372
|
23373
|
23374
|
23375
|
23376
|
23377
|
24561
|
24562
|
24563
|
24564
|
24565
|
24566
|
24567
|
24568
|
29223
|
29224
|
29225
|
29226
|
29227
|
29511
|
29600
|
29601
|
29602
|
29603
|
29604
|
29761
|
30209
|
30210
|
30211
|
30212
|
30213
|
30460
|
30461
|
30462
|
30463
|
30464
|
31091
|
31092
|
31093
|
31094
|
31095
|
31096