Attachment 21228 Details for Bug 10871 – Bug 10871: Make confirmation message for deleting news translatable

[patch] Bug 10871: Make confirmation message for deleting news translatable

Bug-10871-Make-confirmation-message-for-deleting-n.patch (text/plain), 2.02 KB, created by Jonathan Druart on 2013-09-19 10:12:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-09-19 10:12:24 UTC

Size: 2.02 KB

patch

obsolete

>From bce1cb3bc38c7d106c5e3f02136c385dd436b914 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Tue, 10 Sep 2013 21:10:28 +0200
>Subject: [PATCH] Bug 10871: Make confirmation message for deleting news
> translatable
>
>To test:
>- Create a news entry in tools > news
>- Delete the news entry or multiple entries by selecting them
>  using the checkboxes to the left and the delete button at the
>  bottom of the page.
>
>Verify confirmation message shows up correctly with patch applied.
>
>Bonus:
>- Update one of the po files and make sure the new strings shows up
>  there.
>
>Thx Owen!
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>index cc8604d..b92f63a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt
>@@ -23,6 +23,8 @@
> [% END %]
> <script language="javascript" type="text/javascript" src="[% interface %]/lib/tiny_mce/tiny_mce.js"></script>
> <script type="text/javascript">//<![CDATA[
>+var MSG_CONFIRM_DELETE_NEWS  = _("Are you sure you want to delete the selected news?");
>+
> tinyMCE.init({
>     mode : "textareas",
>     theme : "advanced",
>@@ -130,7 +132,7 @@ Edit News Item[% ELSE %]Add News Item[% END %][% ELSE %]News[% END %]</div>
>         </form>
>         </div>
>         [% IF ( opac_news_count ) %]
>-        <form name="del_form" method="post" action="/cgi-bin/koha/tools/koha-news.pl" onsubmit="return confirm('Are you sure you want to delete the selected news?')">
>+        <form name="del_form" method="post" action="/cgi-bin/koha/tools/koha-news.pl" onsubmit='return confirm(MSG_CONFIRM_DELETE_NEWS)'>
>                 <table id="newst">
>                    <thead> <tr>
>                         <th>&nbsp;</th>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10871: 20971 | 20997 | 21126 | 21228