Bugzilla – Attachment 21291 Details for
Bug 10900
Incorrect calling conventions accessing C4::Context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix t/Circulation_barcodedecode.t set_userenv calls
0002-Bug-10900-Incorrect-calling-conventions-accessing-C4.patch (text/plain), 1.99 KB, created by
Mark Tompsett
on 2013-09-21 04:32:47 UTC
(
hide
)
Description:
Fix t/Circulation_barcodedecode.t set_userenv calls
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2013-09-21 04:32:47 UTC
Size:
1.99 KB
patch
obsolete
>From 7ccb73b0486e9daa6d63e37ced395e3d97064531 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Fri, 20 Sep 2013 23:44:02 -0400 >Subject: [PATCH 2/3] Bug 10900 - Incorrect calling conventions accessing > C4::Context > >As the result of trying to roll a distribution, >t/Circulation_barcodedecode.t was discovered to be faulty. The >cause being incorrect parameters! This was hidden when there >was no shift in the set_userenv routine. However, with its >correction, the test broke. > >This led me to read the POD documentation for the function >set_userenv in C4::Context and realize it was outdated as >well. It has been revised to match the current version of >the function. >--- > C4/Context.pm | 7 ++++--- > t/Circulation_barcodedecode.t | 2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/C4/Context.pm b/C4/Context.pm >index 25a06ce..6f523eb 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -1099,9 +1099,10 @@ sub userenv { > > =head2 set_userenv > >- C4::Context->set_userenv($usernum, $userid, $usercnum, $userfirstname, >- $usersurname, $userbranch, $userflags, $emailaddress, $branchprinter, >- $persona); >+ C4::Context->set_userenv($usernum, $userid, $usercnum, >+ $userfirstname, $usersurname, >+ $userbranch, $branchname, $userflags, >+ $emailaddress, $branchprinter, $persona); > > Establish a hash of user environment variables. > >diff --git a/t/Circulation_barcodedecode.t b/t/Circulation_barcodedecode.t >index f76f7fc..f76042c 100644 >--- a/t/Circulation_barcodedecode.t >+++ b/t/Circulation_barcodedecode.t >@@ -6,7 +6,7 @@ use warnings; > > use Test::More tests => 26; > C4::Context->_new_userenv(123456); >-C4::Context->set_userenv(1,'kmkale' , 1, 'kk1' , 'IMS', 0, 'kmkale@anantcorp.com'); >+C4::Context->set_userenv(1,'kmkale' , 1, 'km', 'kale' , 'IMS', 'IMS Branch DEscription', 0, 'kmkale@anantcorp.com'); > > BEGIN { > use_ok('C4::Circulation'); >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10900
:
21152
|
21263
|
21290
|
21291
|
21292
|
22037
|
22038
|
22585
|
22937
|
27729
|
28183
|
30243
|
30244
|
31297
|
31298
|
31719
|
31720
|
31721
|
34355
|
34356
|
34357
|
35542
|
35543
|
35544