Bugzilla – Attachment 21371 Details for
Bug 8015
Add MARC Modifications Templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8015: Followup QA issues
Bug-8015-Followup-QA-issues.patch (text/plain), 1.01 KB, created by
Jonathan Druart
on 2013-09-23 12:39:19 UTC
(
hide
)
Description:
Bug 8015: Followup QA issues
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-09-23 12:39:19 UTC
Size:
1.01 KB
patch
obsolete
>From a46dd6a1b7a4368ee4d2965202babf5f3d098f0b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 23 Sep 2013 14:37:04 +0200 >Subject: [PATCH] Bug 8015: Followup QA issues > >eval { $eval }; != eval $eval; > >my $r = q|/foo/fee/|; >my @values = ("foo", "bar", "foobar"); >for my $v ( @values ) { > eval {"\$v =~ s$r"}; > say $v; > eval "\$v =~ s$r"; > say $v; >} > >will display: > >foo >fee >bar >bar >foobar >feebar >--- > C4/MarcModificationTemplates.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/MarcModificationTemplates.pm b/C4/MarcModificationTemplates.pm >index 2c7bb97..526ab53 100644 >--- a/C4/MarcModificationTemplates.pm >+++ b/C4/MarcModificationTemplates.pm >@@ -563,7 +563,7 @@ sub ModifyRecordWithTemplate { > > C4::Koha::Log("eval $eval") if DEBUG >= 2; > warn("eval $eval") if DEBUG >= 2; >- eval {$eval}; >+ eval $eval; > C4::Koha::Log( $record->as_formatted() ) if DEBUG >= 10; > warn( $record->as_formatted() ) if DEBUG >= 10; > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8015
:
9313
|
9329
|
9330
|
9331
|
10089
|
11579
|
11607
|
11608
|
12280
|
12288
|
12569
|
12570
|
12571
|
12572
|
12839
|
12856
|
12857
|
12858
|
12859
|
12860
|
13121
|
13138
|
13495
|
14030
|
14031
|
14032
|
14033
|
14034
|
14035
|
14040
|
16330
|
16331
|
16332
|
16333
|
16334
|
16335
|
16363
|
16376
|
16377
|
16378
|
16379
|
16413
|
16415
|
16423
|
16455
|
16468
|
16470
|
16471
|
16472
|
16473
|
16475
|
16476
|
16477
|
16478
|
16479
|
16480
|
17036
|
17037
|
17038
|
18372
|
18441
|
21024
|
21025
|
21026
|
21027
|
21028
|
21029
|
21030
|
21031
|
21032
|
21033
|
21034
|
21035
|
21036
|
21037
|
21038
|
21371
|
21484
|
21485
|
21486
|
21487
|
21808
|
21809
|
21876
|
21901
|
21902
|
21903
|
21904
|
21905
|
21906
|
21907
|
21908
|
21909
|
21910
|
21911
|
21912
|
21913
|
21914
|
21915
|
21916
|
21917
|
21918
|
21919
|
21920
|
22185
|
22186
|
22187
|
22188
|
22189
|
22190
|
22284
|
22285
|
22290
|
22293
|
22392
|
22393
|
22394
|
22395
|
22396
|
22397
|
22398
|
22399
|
22400
|
22401