Bugzilla – Attachment 2154 Details for
Bug 4464
Editing a record with a 245a triggers warning about 245 is mandatory
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch to check subfields in <textarea> elements
0001-bug-4464-properly-check-if-a-subfield-is-populated-i.patch (text/plain), 1.45 KB, created by
Galen Charlton
on 2010-05-21 17:02:36 UTC
(
hide
)
Description:
patch to check subfields in <textarea> elements
Filename:
MIME Type:
Creator:
Galen Charlton
Created:
2010-05-21 17:02:36 UTC
Size:
1.45 KB
patch
obsolete
>From 78f52392038dc2ea1df0f0c4d9069952c37a6eda Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmcharlt@gmail.com> >Date: Fri, 21 May 2010 12:57:41 -0400 >Subject: [PATCH] bug 4464: properly check if a subfield is populated if it is in a textarea > >Subfields whose contents are longer than 100 characters are represented on the >bib form using a <textarea> instead of a text <input>. The check on whether >at least one subfield for a mandatory field is populated wasn't not >checking for <textarea> subfields. > >Signed-off-by: Galen Charlton <gmcharlt@gmail.com> >--- > .../prog/en/modules/cataloguing/addbiblio.tmpl | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl >index 6c4a2c4..3e41f04 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl >@@ -148,6 +148,14 @@ function AreMandatoriesNotOk(){ > } > } > } >+ >+ elemtextareas = elem.getElementsByTagName('textarea'); >+ for(var j=0,len2=elemtextareas.length; j<len2; j++){ >+ // this bit assumes that the only textareas in this context would be for subfields >+ if (elemtextareas[j].value) { >+ isempty = false; >+ } >+ } > }else{ > isempty = false; > } >-- >1.7.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4464
:
2121
| 2154