Bugzilla – Attachment 21563 Details for
Bug 9044
Allow to select items on catalogue/detail.pl and trigger actions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9044: QA followup
SIGNED-OFF-Bug-9044-QA-followup.patch (text/plain), 3.93 KB, created by
Bernardo Gonzalez Kriegel
on 2013-09-29 02:05:14 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9044: QA followup
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2013-09-29 02:05:14 UTC
Size:
3.93 KB
patch
obsolete
>From 4f24ac86889f235394e41cd72c9905027624d567 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 17 Jun 2013 12:11:27 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 9044: QA followup > >1/ Remove filter and sort for the checkboxes column. >2/ Enable the pref by default. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >--- > installer/data/mysql/sysprefs.sql | 2 +- > installer/data/mysql/updatedatabase.pl | 2 +- > .../prog/en/modules/catalogue/detail.tt | 8 ++++++++ > 3 files changed, 10 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index f3e5078..76a0010 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -348,7 +348,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('SpineLabelShowPrintOnBibDetails','0','','If turned on, a \"Print Label\" link will appear for each item on the bib details page in the staff interface.','YesNo'), > ('StaffAuthorisedValueImages','1',NULL,'','YesNo'), > ('staffClientBaseURL','',NULL,'Specify the base URL of the staff client','free'), >-('StaffDetailItemSelection', '0', NULL, 'Enable item selection in record detail page', 'YesNo'); >+('StaffDetailItemSelection', '1', NULL, 'Enable item selection in record detail page', 'YesNo'); > ('StaffSerialIssueDisplayCount','3','','Number of serial issues to display per subscription in the Staff client','Integer'), > ('StaticHoldsQueueWeight','0',NULL,'Specify a list of library location codes separated by commas -- the list of codes will be traversed and weighted with first values given higher weight for holds fulfillment -- alternatively, if RandomizeHoldsQueueWeight is set, the list will be randomly selective','Integer'), > ('SubfieldsToUseWhenPrefill','','','Define a list of subfields to use when prefilling items (separated by space)','Free'), >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index f0771ad..ed308f4 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -7158,7 +7158,7 @@ $DBversion = "XXX"; > if ( CheckVersion($DBversion) ) { > $dbh->do(qq{ > INSERT INTO systempreferences (variable, value, explanation, options, type) >- VALUES ('StaffDetailItemSelection', '0', 'Enable item selection in record detail page', NULL, 'YesNo') >+ VALUES ('StaffDetailItemSelection', '1', 'Enable item selection in record detail page', NULL, 'YesNo') > }); > print "Upgrade to $DBversion done (Add system preference StaffDetailItemSelection)\n"; > SetVersion($DBversion); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 1f8274b..7914ee9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -149,6 +149,9 @@ function verify_images() { > if (table.find('thead tr.columnFilter').length == 0) { > table.dataTable().columnFilter({ > 'sPlaceHolder': 'head:after' >+ [% IF StaffDetailItemSelection %] >+ , aoColumns: [ null, 'text', 'text', 'text', 'text', 'text', 'text', 'text' ] >+ [% END %] > }); > filters_row.addClass('columnFilter'); > } >@@ -198,6 +201,11 @@ function verify_images() { > 'sDom': 't', > 'bPaginate': false, > 'bAutoWidth': false >+ [% IF StaffDetailItemSelection %] >+ , "aoColumnDefs": [ >+ { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false } >+ ] >+ [% END %] > })); > > // Show a link to activate filtering >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9044
:
13344
|
13513
|
13933
|
14737
|
16612
|
16707
|
16708
|
16711
|
19060
|
19344
|
19913
|
19914
|
19915
|
19916
|
21324
|
21325
|
21326
|
21327
|
21561
|
21562
|
21563
|
21564
|
21591
|
21634
|
21683
|
21745
|
21746
|
21747
|
21748
|
21749