Bugzilla – Attachment 21598 Details for
Bug 10689
public note does not appear in subscriptions search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10689 - public note does not appear in subscriptions search
SIGNED-OFF-Bug-10689---public-note-does-not-appear.patch (text/plain), 3.12 KB, created by
Bernardo Gonzalez Kriegel
on 2013-09-29 16:45:28 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10689 - public note does not appear in subscriptions search
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2013-09-29 16:45:28 UTC
Size:
3.12 KB
patch
obsolete
>From c8b63c30b574d7a6a44f137203899710ebc5049d Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Tue, 6 Aug 2013 12:13:34 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 10689 - public note does not appear in > subscriptions search > >In a serials module, when searching subscriptions, the results table as a "Notes" column. >In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". >Internal note is well displayed but not public note. >You can see the 2 notes in serial details in summary tab. > >The problem commes from the SQL query. A join is perform on subscription and biblio, both containing a "notes" column. >This patch solves the problem by using a alias in query for both columns (biblio.notes is acutally not used in template but could be). > >Test plan : >- Edit a subscription >- Add public and internal notes. For example : "too busy" and "on holiday" >- Perform a subscription search that returns this subscription >=> "Notes" column contains both notes. For example : "too busy (on holiday)" >- Test with only public note >- Test with only internal note > >==== >Works as described. >Signed-off-by:Mathieu Saby <mathieu.saby@uhb.fr> >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Adding a sign >--- > C4/Serials.pm | 9 ++++++++- > .../prog/en/modules/serials/serials-search.tt | 2 +- > 2 files changed, 9 insertions(+), 2 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index a1ce054..a2498c8 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -654,7 +654,14 @@ sub SearchSubscriptions { > my ( $args ) = @_; > > my $query = qq{ >- SELECT subscription.*, subscriptionhistory.*, biblio.*, biblioitems.issn >+ SELECT >+ subscription.notes AS publicnotes, >+ subscription.*, >+ subscriptionhistory.*, >+ biblio.notes AS biblionotes, >+ biblio.title, >+ biblio.author, >+ biblioitems.issn > FROM subscription > LEFT JOIN subscriptionhistory USING(subscriptionid) > LEFT JOIN biblio ON biblio.biblionumber = subscription.biblionumber >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >index 459a80a..7b2803a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >@@ -148,7 +148,7 @@ > </td> > <td><a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscription.subscriptionid %]" class="button" title="subscription detail">[% subscription.title |html %]</a> > </td> >- <td>[% IF ( subscription.notes ) %][% subscription.notes %][% END %] >+ <td>[% IF ( subscription.publicnotes ) %][% subscription.publicnotes %][% END %] > [% IF ( subscription.internalnotes ) %]([% subscription.internalnotes %])[% END %] > </td> > <td> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10689
:
20124
|
20125
|
21100
|
21207
|
21598
|
21599
|
21602
|
21603