Attachment 21700 Details for Bug 6113 – Bug 6113 [ENH] - enhancement to keep previous ids

[patch] Bug 6113 [ENH] - enhancement to keep previous ids

Bug-6113-ENH---enhancement-to-keep-previous-ids.patch (text/plain), 2.52 KB, created by Olli-Antti Kivilahti on 2013-10-01 14:33:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olli-Antti Kivilahti

Created: 2013-10-01 14:33:05 UTC

Size: 2.52 KB

patch

obsolete

>From 68554041990be3dcdc357b7104d24e2f39d50d39 Mon Sep 17 00:00:00 2001
>From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
>Date: Tue, 1 Oct 2013 16:29:30 +0300
>Subject: [PATCH] Bug 6113 [ENH] - enhancement to keep previous ids
>
>Forgot the extra warnings in C4::Biblio.
>Removed double warnings.
>---
> C4/Biblio.pm | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/C4/Biblio.pm b/C4/Biblio.pm
>index 099be45..0ba0eda 100644
>--- a/C4/Biblio.pm
>+++ b/C4/Biblio.pm
>@@ -2952,17 +2952,14 @@ sub _koha_add_biblio {
>         $biblionumber = $biblio->{'biblionumber'};
>         if (! ($biblionumber =~ /^\d+$/) ) {
>             $error .= "C4::Biblio::_koha_add_biblio():> Biblionumber $biblionumber is not a number! Using a new biblionumber\n";
>-            warn $error;
>         }
>         elsif (! ($biblionumber > 0)) {
>             $error .= "C4::Biblio::_koha_add_biblio():> Biblionumber $biblionumber is not greater than 0! Using a new biblionumber\n";
>-            warn $error;
>         }
>         #The real Perl LONG_MAX is 2147483646, but using 2147483640
>         #  so we can detect the imminent primary key exhaustion before it actually is exhausted.
>         elsif (! ($biblionumber < 2147483640)) { 
>             $error .= "C4::Biblio::_koha_add_biblio():> Biblionumber $biblionumber is too large for Perl! Using a new biblionumber\n";
>-            warn $error;
>         }
>         else {
>             #We have validated the biblionumber and can prepare to insert it.
>@@ -3143,17 +3140,14 @@ sub _koha_add_biblioitem {
>         $biblioitemnumber = $biblioitem->{'biblioitemnumber'};
>         if (! ($biblioitemnumber =~ /^\d+$/) ) {
>             $error .= "C4::Biblio::_koha_add_biblioitem():> biblioitemnumber $biblioitemnumber is not a number! Using a new biblioitemnumber\n";
>-            warn $error;
>         }
>         elsif (! ($biblioitemnumber > 0)) {
>             $error .= "C4::Biblio::_koha_add_biblioitem():> biblioitemnumber $biblioitemnumber is not greater than 0! Using a new biblioitemnumber\n";
>-            warn $error;
>         }
>         #The real Perl LONG_MAX is 2147483646, but using 2147483640
>         #  so we can detect the imminent primary key exhaustion before it actually is exhausted.
>         elsif (! ($biblioitemnumber < 2147483640)) { 
>             $error .= "C4::Biblio::_koha_add_biblioitem():> biblioitemnumber $biblioitemnumber is too large for Perl! Using a new biblioitemnumber\n";
>-            warn $error;
>         }
>         else {
>             #We have validated the biblionumber and can prepare to insert it.
>-- 
>1.8.1.2

Actions: View | Diff | Splinter Review

Attachments on bug 6113: 3845 | 6527 | 21698 | 21699 | 21700 | 21701 | 21702 | 21703 | 24073